1924771 - TypedArray compartment test isn't testing separate compartments

Status: NEW

(Core :: JavaScript: Standard Library, task, P3)

Description

[Bryan Thrall [:bthrall]]

The TypedArray of.js test for behavior across compartments doesn't create a new compartment. Apparently, newGlobal() used to create a new compartment by default, but no longer does.

Comment 1

[Bryan Thrall [:bthrall]]

Attachment: Bug 1924771 - Make TypedArray compartment test actually test separate compartments r=mgaudet!

These tests are apparently from a time when each newGlobal() created a
separate compartment by default, which is no longer the case.

There are many other tests that check calls from "other globals," but it isn't
clear if they are just concerned with the globals or they actually want a
separate compartment.

Comment 2

[Jon Coppeard (:jonco)]

Our tests get run with the --tbpl option in CI which runs each one in a bunch of different configurations. At least one if these should have the --more-compartments option, which does make newGlobal create a separate compartment. So, we should still have test coverage here even if it may not test what we expect when run locally with the default options.

Comment 3

[Bryan Thrall [:bthrall]]

Should I just close this bug, then? It sounds like the problem I thought I saw isn't really a problem.

Comment 4

[Bryan Thrall [:bthrall]]

:jonco, unless you see some value here, I'm going to close this bug.

Comment 5

[Jon Coppeard (:jonco)]

Sorry I missed this needinfo.

If the test is explicitly testing something that requires separate compartments, then it should create a new compartment. Failure to do so means we won't test what we're trying to test unless we run with --tbpl and I assume most people don't run tests locally with this option. Plus it's confusing, hence this bug.

However it's not a super big deal since we do still get the test coverage we want on CI.