1924806 - add pipewire support to mochitest harness

Status: RESOLVED FIXED

(Testing :: Mochitest, task)

Description

[Julien Cristau [:jcristau] (back August 18)]

Newer linux distros have different output from pactl, that mochitest needs to learn to parse before we can move wayland tests from ubuntu 22.04 to 24.04.

Comment 1

[Julien Cristau [:jcristau] (back August 18)]

Paul, in bug 1763403 you added module-sine-source to the pulseaudio setup; pipewire doesn't seem to have that module (pactl load-module fails with Failure: No such entity), do you know if there's a replacement we should use?

Comment 2

[Julien Cristau [:jcristau] (back August 18)]

Attachment: Bug 1924806

Comment 3

[Julien Cristau [:jcristau] (back August 18)]

FWIW the errors are visible in https://treeherder.mozilla.org/jobs?repo=try&revision=6efdbb79d5e2ef456fdc71de1ac3b16f7a676440&selectedTaskRun=Ck1bZippSYmfR7FrMA_PTw.0

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1924806 - Set up new input and output devices when the host uses pipewire. r?jcristau

Comment 5

[Paul Adenot (:padenot)]

Not finished but we're getting somewhere.

Comment 6

[Julien Cristau [:jcristau] (back August 18)]

Attachment: Bug 1924806 - enable audiotestsrc pipewire plugin on ubuntu 24.04

Comment 7

[Julien Cristau [:jcristau] (back August 18)]

Andreas, any chance you could help me with this? With the WIP patch stack to run tests on 24.04, the media tests are unhappy, see e.g. https://treeherder.mozilla.org/jobs?repo=try&revision=474ea1dd394c70b1f3b6aad43e6b89ee74cd19bb&searchStr=mda

Comment 8

[Julien Cristau [:jcristau] (back August 18)]

Attachment: Bug 1924806 - stop creating null pulseaudio sink in mozharness

The mochitest harness handles creating the null devices.

Comment 9

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1924806 - Signal speaker via findTestMediaDevices like microphone and camera. r?jcristau

Comment 10

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1924806 - Unify lifetime of null sinks and sine sources with pipewire. r?jcristau

Comment 11

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1924806 - Don't use spaces in names of audio devices. r?jcristau

When pipewire node names contain spaces, they can't be opened through
pipewire-pulse (pa_stream_connect_record). Unclear why, as pavucontrol can
monitor their volume just fine. A safe bet is to remove spaces from the names we
set explicitly. This patch in addition adds user-friendly descriptions that do
contain spaces to the devices. It also sets the pulseaudio null-sink name
properly, so we can rely on a single name across both pipewire and pulseaudio.

Comment 12

[Andreas Pehrson [:pehrsons]]

Both 24.04 and 18.04 seem happy now: https://treeherder.mozilla.org/jobs?repo=try&revision=a50279718e4a741070cd2db298f9ad71ade551d5

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47e244df3141
enable audiotestsrc pipewire plugin on ubuntu 24.04 r=jmaher
https://hg.mozilla.org/integration/autoland/rev/938b607cd6f5
Set up new input and output devices when the host uses pipewire. r=jcristau
https://hg.mozilla.org/integration/autoland/rev/2ed8a658bb50
Signal speaker via findTestMediaDevices like microphone and camera. r=jcristau
https://hg.mozilla.org/integration/autoland/rev/6ad932a53cf2
Unify lifetime of null sinks and sine sources with pipewire. r=jcristau
https://hg.mozilla.org/integration/autoland/rev/d77ca9139e6e
Don't use spaces in names of audio devices. r=jcristau

Comment 14

[amarc]

https://hg.mozilla.org/mozilla-central/rev/47e244df3141
https://hg.mozilla.org/mozilla-central/rev/938b607cd6f5
https://hg.mozilla.org/mozilla-central/rev/2ed8a658bb50
https://hg.mozilla.org/mozilla-central/rev/6ad932a53cf2
https://hg.mozilla.org/mozilla-central/rev/d77ca9139e6e