1924850 - Update appmenu top-level menuitem as state changes

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement, P1)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Right now the top-level profiles entry in the app menu is only updated the first time the app menu is displayed for a given window. We should redraw it either when profile state changes, or eagerly on each appmenu open, so that we don't show stale name/avatar/theme for a given profile.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I'll fix this as part of the sync menu popup addition in bug 1927562

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1924850: Update appmenu top-level menuitem as state changes. r?niklas,mossop

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce1ce2a8cacd
Update appmenu top-level menuitem as state changes. r=mossop

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_menubar_profiles

Backout link: https://hg.mozilla.org/integration/autoland/rev/3c04841f5975ca656ba0b025ebe4acac3a9eb850

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/profiles/browser_menubar_profiles.js | menu should be visible when preffed on - true == false

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3590cf454bc
Update appmenu top-level menuitem as state changes. r=mossop

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a3590cf454bc