Closed Bug 1924933 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 48637 - webnn: Make MLOperandDescriptor.shape a required dictionary member

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox133 fixed)

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox133 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48637 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48637
Details from upstream follow.

Austin Sullivan <asully@chromium.org> wrote:

webnn: Make MLOperandDescriptor.shape a required dictionary member

See https://github.com/webmachinelearning/webnn/issues/758

Also removes the temporary support for passing "dimensions" which was
added in https://crrev.com/e7e99aa5

Bug: 365813262
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,win11-blink-rel
Change-Id: Ib714ae540da7fbd7d55365dc739bfb8dbf266406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5850659
Reviewed-by: ningxin hu \<ningxin.hu@intel.com>
Commit-Queue: ningxin hu \<ningxin.hu@intel.com>
Auto-Submit: Austin Sullivan \<asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1369192}

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests and 8 subtests

Status Summary

Firefox

OK : 12
FAIL: 156

Chrome

OK : 12
PASS: 156

Safari

OK : 12
FAIL: 156

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /webnn/validation_tests/constant.https.any.worker.html?gpu [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a 0-D scalar constant with empty dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with float32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for float32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int64 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint64 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int8 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int8 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint8 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint8 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if a dimension is 0: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if bufferView type doesn't match the operand data type: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/constant.https.any.html?npu [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a 0-D scalar constant with empty dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with float32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for float32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int64 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint64 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int8 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int8 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint8 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint8 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if a dimension is 0: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if bufferView type doesn't match the operand data type: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/constant.https.any.worker.html?cpu [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a 0-D scalar constant with empty dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with float32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for float32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int64 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint64 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int8 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int8 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint8 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint8 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if a dimension is 0: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if bufferView type doesn't match the operand data type: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/constant.https.any.worker.html?npu [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a 0-D scalar constant with empty dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with float32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for float32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int64 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint64 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int8 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int8 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint8 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint8 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if a dimension is 0: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if bufferView type doesn't match the operand data type: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/constant.https.any.html?cpu [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a 0-D scalar constant with empty dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with float32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for float32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int64 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint64 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int8 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int8 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint8 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint8 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if a dimension is 0: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if bufferView type doesn't match the operand data type: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/constant.https.any.html?gpu [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a 0-D scalar constant with empty dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with float32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for float32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint32 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint32 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int64 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint64 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with int8 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for int8 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Test building a constant with uint8 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if byte length of bufferView for uint8 doesn't match the given dimensions: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if a dimension is 0: FAIL (Chrome: PASS, Safari: FAIL)
    • [constant] Throw if bufferView type doesn't match the operand data type: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/input.https.any.worker.html?cpu [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 0-D scalar input with empty shape: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 1-D input with int64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 2-D input without errors: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the name is empty: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if a dimension size is 0: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the value of any element in dimensions is outside the 'unsigned long' value range: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the number of elements is too large: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/input.https.any.html?gpu [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 0-D scalar input with empty shape: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 1-D input with int64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 2-D input without errors: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the name is empty: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if a dimension size is 0: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the value of any element in dimensions is outside the 'unsigned long' value range: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the number of elements is too large: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/input.https.any.html?npu [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 0-D scalar input with empty shape: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 1-D input with int64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 2-D input without errors: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the name is empty: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if a dimension size is 0: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the value of any element in dimensions is outside the 'unsigned long' value range: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the number of elements is too large: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/input.https.any.html?cpu [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 0-D scalar input with empty shape: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 1-D input with int64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 2-D input without errors: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the name is empty: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if a dimension size is 0: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the value of any element in dimensions is outside the 'unsigned long' value range: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the number of elements is too large: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/input.https.any.worker.html?npu [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 0-D scalar input with empty shape: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 1-D input with int64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 2-D input without errors: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the name is empty: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if a dimension size is 0: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the value of any element in dimensions is outside the 'unsigned long' value range: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the number of elements is too large: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/input.https.any.worker.html?gpu [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 0-D scalar input with empty shape: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 1-D input with int64 data type: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Test building a 2-D input without errors: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the name is empty: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if a dimension size is 0: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the value of any element in dimensions is outside the 'unsigned long' value range: FAIL (Chrome: PASS, Safari: FAIL)
    • [input] Throw if the number of elements is too large: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f95e773e94f [wpt PR 48637] - webnn: Make MLOperandDescriptor.shape a required dictionary member, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9f95e773e94f

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.