1924955 - [wpt-sync] Sync PR 48642 - DOM: Make moveBefore() throw for all pre-move validity checks

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48642 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48642
Details from upstream follow.

Dominic Farolino <[e-mail]> wrote:

DOM: Make moveBefore() throw for all pre-move validity checks

This CL makes moveBefore() match the spec PR 1, with regard to the
agreed-upon error-throwing behavior for all pre-moving validity and
hierarchy conditions. This means throwing an exception for:

• Disconnected parent destination or move target
• Cross-document Nodes
• Destination parent that is not an Element node
• Move target that is not an Element or character data

R=[e-mail]

Bug: 40150299
Change-Id: Iaf5243fb2762e21ede068a222600bd158859fe92

Reviewed-on: https://chromium-review.googlesource.com/5935350
WPT-Export-Revision: e41cc0099e501db0c9d4acee162b5bcd70a630ca

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=90079b153d9f400e2911a5e1374d8aee9d15744e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 1 subtests

Status Summary

Firefox

OK : 4
PASS : 6
FAIL : 27
TIMEOUT: 2

Chrome

OK : 5
PASS : 6
FAIL : 28

Safari

OK : 5
PASS : 6
FAIL : 28

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /dom/nodes/moveBefore/tentative/css-transition-cross-document.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] linked bug:Bug 1894184

New Tests That Don't Pass

• /dom/nodes/moveBefore/tentative/css-transition-cross-document.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: OK)
  • Moving a transition across documents should reset its state: TIMEOUT (Chrome: FAIL, Safari: FAIL)
• /dom/nodes/moveBefore/tentative/Node-moveBefore.html [wpt.fyi]
  • If node is a host-including inclusive ancestor of parent, then throw a HierarchyRequestError DOMException.: FAIL (Chrome: FAIL, Safari: FAIL)
  • If node is not a DocumentFragment, DocumentType, Element, Text, ProcessingInstruction, or Comment node, then throw a HierarchyRequestError DOMException.: FAIL (Chrome: FAIL, Safari: FAIL)
  • If node is a Text node and parent is a document, then throw a HierarchyRequestError DOMException.: FAIL (Chrome: FAIL, Safari: FAIL)
  • If node is a doctype and parent is not a document, then throw a HierarchyRequestError DOMException.: FAIL (Chrome: FAIL, Safari: FAIL)
  • If node is a DocumentFragment with multiple elements and parent is a document, then throw a HierarchyRequestError DOMException.: FAIL (Chrome: FAIL, Safari: FAIL)
  • If node is a DocumentFragment with an element and parent is a document with another element, then throw a HierarchyRequestError DOMException.: FAIL (Chrome: FAIL, Safari: FAIL)
  • If node is an Element and parent is a document with another element, then throw a HierarchyRequestError DOMException.: FAIL (Chrome: FAIL, Safari: FAIL)
  • If node is a doctype and parent is a document with another doctype, then throw a HierarchyRequestError DOMException.: FAIL (Chrome: FAIL, Safari: FAIL)
  • If node is a doctype and parent is a document with an element, then throw a HierarchyRequestError DOMException.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Calling moveBefore an a leaf node DocumentType must throw HIERARCHY_REQUEST_ERR.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Calling moveBefore an a leaf node Text must throw HIERARCHY_REQUEST_ERR.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Calling moveBefore an a leaf node Comment must throw HIERARCHY_REQUEST_ERR.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Calling moveBefore an a leaf node ProcessingInstruction must throw HIERARCHY_REQUEST_ERR.: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore() on disconnected parent throws a HierarchyRequestError: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore() with disconnected target node throws a HierarchyRequestError: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore() on a cross-document target node throws a HierarchyRequestError: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore() into a Document throws a HierarchyRequestError: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore() into a CharacterData throws a HierarchyRequestError: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore() with node being an inclusive ancestor of parent throws a HierarchyRequestError: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore() with a non-{Element, CharacterData} throws a HierarchyRequestError: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore with an Element or CharacterData succeeds: FAIL (Chrome: FAIL, Safari: FAIL)
  • moveBefore with reference child whose parent is NOT the destination parent (context node) throws a NotFoundError.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Inserting a node before itself should not move the node: FAIL (Chrome: FAIL, Safari: FAIL)
• /dom/nodes/moveBefore/tentative/css-transition-to-disconnected-document.html [wpt.fyi]
  • Moving an element with a transition to a disconnected document should reset the transitionm state: FAIL (Chrome: FAIL, Safari: FAIL)
• /dom/nodes/moveBefore/tentative/relevant-mutations.html [wpt.fyi]
  • Moving <source> out of <picture> triggers a relevant mutation on sibling <img>: FAIL (Chrome: FAIL, Safari: FAIL)
  • Moving <img> into a <picture> triggers a relevant mutation on the <img>, loading <source>: FAIL (Chrome: FAIL, Safari: FAIL)
• /dom/nodes/moveBefore/tentative/throws-exception.html [wpt.fyi]
  • moveBefore() on a cross-document target node: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /dom/nodes/moveBefore/tentative/css-transition-cross-document.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: OK) linked bug:Bug 1894184

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a83a47312c5d
[wpt PR 48642] - DOM: Make moveBefore() throw for all pre-move validity checks, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a553eeb58a08
[wpt PR 48642] - Update wpt metadata, a=testonly

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/a83a47312c5d
https://hg.mozilla.org/mozilla-central/rev/a553eeb58a08