1925130 - [wpt-sync] Sync PR 48654 - Remove TextCluster caching in TextMetrics

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48654 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48654
Details from upstream follow.

Andres Ricardo Perez <[e-mail]> wrote:

Remove TextCluster caching in TextMetrics

In a previous CL, the getTextClusters() API was implemented with a cache
for the created TextCluster objects. This API may include as a parameter
a dictionary with text align and baseline options. Since the cache is
used if it was already calculated, subsequent calls with different
options return clusters in the wrong positions.

This CL removes this cache to guarantee that the results are always
calculated from scratch taking into account the current options passed

Tests were added using the CanvasTest font to check that the positions
are coherent with the options passed.

A future CL with reincorporate this cache in a way that allows
offsetting the stored clusters following the current align and
baseline options passed.

Bug: 341213359
Change-Id: I4cabdb62d05a9c8763300c0d268d7794ca9f160b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5933690
Reviewed-by: Jean-Philippe Gravel \<[e-mail]>
Commit-Queue: Andres Ricardo Perez \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1369650}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5b49cd3e891cbda42aa42a7371fd5961eab68c3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 3
FAIL: 3

Chrome

OK : 3
FAIL: 3

Safari

OK : 3
FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/text/2d.text.measure.text-clusters-position.tentative.html [wpt.fyi]
  • Test that TextMetrics::getTextClusters() returns clusters that are positioned according to the target align and baseline passed as options.: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/offscreen/text/2d.text.measure.text-clusters-position.tentative.html [wpt.fyi]
  • Test that TextMetrics::getTextClusters() returns clusters that are positioned according to the target align and baseline passed as options.: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/offscreen/text/2d.text.measure.text-clusters-position.tentative.worker.html [wpt.fyi]
  • Test that TextMetrics::getTextClusters() returns clusters that are positioned according to the target align and baseline passed as options.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbf91baafef2
[wpt PR 48654] - Remove TextCluster caching in TextMetrics, a=testonly
https://hg.mozilla.org/integration/autoland/rev/25e88b73966f
[wpt PR 48654] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dbf91baafef2
https://hg.mozilla.org/mozilla-central/rev/25e88b73966f