Ship Interventions v133.2.0 out-of-band
Categories
(Web Compatibility :: Interventions, task, P1)
Tracking
(firefox-esr128 fixed, firefox132 fixed, firefox133 fixed)
People
(Reporter: denschub, Assigned: denschub)
References
(Depends on 1 open bug)
Details
(Whiteboard: [qa-triaged])
Attachments
(2 files, 2 obsolete files)
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr128+
|
Details | Review |
We have a bunch of interventions in the queue:
- Bug 1779908 -
play.google.com
- Bug 1836872 -
docs.google.com
- Bug 1841730 -
korg.com
- Bug 1856915 -
login.yahoo.com
- Bug 1879879 -
developers.pinterest.com
- Bug 1886616 -
six-group.co
- Bug 1895051 -
zhihu.com
- Bug 1896349 -
vivaldi.com
- Bug 1899948 -
tv.partner.co.il
- Bug 1916407 -
give.umrelief.org
- Bug 1919004 -
editoracontexto.com.br
- Bug 1921410 -
beta.maps.apple.com
- Bug 1922175 -
app.livingsecurity.com
- Bug 1924500 -
tiktok.com
The TikTok one is fairly critical, and driving this out-of-band release for now.
Assignee | ||
Comment 1•20 days ago
•
|
||
The following interventions are not covered by automated tests, and need manual testing:
- Bug 1841730 -
korg.com
- Bug 1895051 -
zhihu.com
Bug 1916407 -(Android-only, so out of scope for the OOB rollout)give.umrelief.org
- Bug 1924500 -
tiktok.com
Assignee | ||
Updated•20 days ago
|
Assignee | ||
Comment 2•20 days ago
•
|
||
A couple of interventions, and the update itself, need manual testing. Tests need to happen on Desktop only (so no mobile tests). Because we plan to also target ESR 128 in this update, we need to test in an unbranded 131 build, and in a regular ESR 128 build.
Raul, I'll needinfo you here so you can own this - you have done this kind of testing before, so you're the expert now. But please feel free to delegate, of course! If there are any questions or problems, I'm happy to help - just poke me.
Links to the builds to test
- Unbranded Release 131.0.3: Windows, macOS, Linux
- ESR 128 (128.3.1esr): Please use the regular ESR build, downloaded from the Mozilla website - no special build needed
Test steps
- Open the Firefox build with a blank profile. Go to
about:support
and verify that the "Firefox Features"/"Nightly Features" section shows the currently released version of the "Web Compatibility Interventions" addon:- For the 131 release:
130.2.0
- For the ESR 128:
128.5.0
- For the 131 release:
- Open
about:config
, and create a new boolean pref with namedxpinstall.signatures.dev-root
, and make sure it's set totrue
. - Open this URL - you should be asked to install an addon and grant its permissions. Installation should work without problems.
- Open
about:support
again. "Web Compatibility Interventions" should no longer be listed in the "Features" sectoin. Verify that "Web Compatibility Interventions" now shows up int he "Add-ons" section, and verify that the version number is133.2.20241017.92612
. - Open
about:compat
, and verify that it loads and shows a list of interventions. - Please verify that the following Site Reports no longer reproduce:
- (Windows 10 only) Bug 1841730
- Bug 1895051
- Bug 1924500
- Restart Firefox, keep using the same profile.
- After the restart, open
about:support
again, verify that the version number still shows133.2.20241017.92612
, and thatabout:compat
still works.
After successful tests
Please write a sign-off comment in this bug, as well as this Jira ticket just so that the papertrail is clear.
Comment 3•20 days ago
|
||
Updated•20 days ago
|
Updated•20 days ago
|
Comment 4•20 days ago
|
||
Updated•20 days ago
|
Comment 5•20 days ago
|
||
Updated•20 days ago
|
Comment 6•20 days ago
|
||
Updated•20 days ago
|
Comment 7•20 days ago
|
||
esr128 Uplift Approval Request
- User impact if declined: Some TikTok captchas will not be usable, several other sites will continue locking out Firefox users, and other websites will continue to exhibit various web compatibility issues.
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: See the bug for info on which sites will be affected per release branch. Only the TikTok fix definitely needs to be verified; the others are comparitively low severity and priority.
- Risk associated with taking this patch: Low
- Explanation of risk level: This only affects our webcompat built-in addon. We are also shipping an out-of-band release of the addon matching these uplift requests anyway, and this patch is just to keep everything in sync (see bug for more info). Automated tests do not cover all site fixes; the bug lists which, but the desktop-only TikTok one is the most important..
- String changes made/needed: none
- Is Android affected?: yes
Updated•20 days ago
|
Updated•20 days ago
|
Updated•20 days ago
|
Comment 8•20 days ago
|
||
For posterity, bug 1899948 is where the addon got bumped to v133.2.0 on Nightly.
Comment 9•20 days ago
|
||
release Uplift Approval Request
- User impact if declined: Some TikTok captchas will not work, and some other websites will continue to not work on Firefox, or have other web compatibilty issues.
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: See the bug for details on which bugs were fixed on which sites. The most important thing to verify is that the slider-based captchas on TikTok work; the other fixes have lower priority and severity.
- Risk associated with taking this patch: Low
- Explanation of risk level: Only affects the webcompat built-in addon and specific web sites that either are broken to begin with on Firefox, or fix minor issues with simple methods.
- String changes made/needed: none
- Is Android affected?: yes
Comment 10•20 days ago
|
||
beta Uplift Approval Request
- User impact if declined: Some TikTok captchas will not work, and some other websites will continue to not work on Firefox, or have other web compatibilty issues.
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: See the bug for details on which bugs were fixed on which sites. The most important thing to verify is that the slider-based captchas on TikTok work; the other fixes have lower priority and severity.
- Risk associated with taking this patch: Low
- Explanation of risk level: Only affects the webcompat built-in addon and specific web sites that either are broken to begin with on Firefox, or fix minor issues with simple methods.
- String changes made/needed: none
- Is Android affected?: yes
Comment 11•19 days ago
•
|
||
We have completed the tests following the steps described here. Below are the results:
Estimated time spent
: 1h
- 1841730 www.korg.com - Page doesn't finish loading (Windows 10 only) :
Unbranded Release 131.0.3: the page finishes loading
ESR 128 (128.3.1esr): the page finishes loading
- 1895051 www.zhihu.com - "目录" (Directory) button in the answer is unclickable
This is sometimes A/B testing, as the UI of the page loaded does not allow the button to be clicked, this happens on all browsers
When the button is clickable:
Unbranded Release 131.0.3: the button responds and options are triggered
ESR 128 (128.3.1esr): the button responds and options are triggered
- 1924500 www.tiktok.com - Activation captcha to solve a puzzle for login purposes does not respond to mouse drag action
Unbranded Release 131.0.3: the captcha responds to mouse drag when triggered and login can be performed
ESR 128 (128.3.1esr): the captcha responds to mouse drag when triggered and login can be performed
Tested with:
Browser / Version: Unbranded Release 131.0.3: custom build/ESR 128 (128.3.1esr) regular build
Operating System: Windows 10 PRO x64
Operating System: Ubuntu 22.4 LTS x64
Operating System: Mac Ventura 13.1/ Mac OS Sonoma 14.1.3
Assignee | ||
Comment 12•19 days ago
|
||
In the second, and final, round of tests - please use regular Firefox Release builds, and regular Firefox ESR builds. So not the unbranded builds from earlier. The tests need to be run in Firefox Release 131.0.3, and Firefox ESR 128.3.1esr, on Windows, macOS, and Linux.
We're testing only that the update applies cleanly, and doesn't break the addon - so we won't be testing all interventions again, and instead just focus on TikTok.
- In a fresh profile, confirm that on
about:support
, in theFirefox Features
section, it showsWeb Compatibility Interventions
with the current version -130.2.0
in Firefox Release, and128.5.0
in Firefox ESR. - Open
about:config
, editextensions.systemAddon.update.url
, and set it tohttps://aus5.mozilla.org/update/3/SystemAddons/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/release-sysaddon/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml
- Open the Firefox DevTools. In the DevTools, open the Settings via the Three-Dot-Menu -> Settings. In there, enable the checkbox
Enable browser chrome and add-on debugging toolboxes
. - Open the Firefox Browser Console:
- on Linux and Windows, press Ctrl+Shift+J to open it
- on macOS, it's Cmd+Shift+J
- In that new console, run
Components.utils.import("resource://gre/modules/AddonManager.jsm"); AddonManagerPrivate.backgroundUpdateCheck();
- You won't see any progress, the update happens in the background. Wait 30 seconds, just to make sure Firefox has enough time to download and apply all updates.
- Head back to
about:support
, and confirm that the Interventions version number now shows133.2.20241017.92612
- Check that
about:compat
loads and shows a list of active interventions. - Verify that the "broken captcha" on TikTok as per Bug 1924500 is no longer broken.
- Restart Firefox, keeping the same profile. Verify that the version number in
about:support
is still133.2.20241017.92612
, and that the TikTok captcha still works.
Comment 13•19 days ago
|
||
uplift |
Updated•19 days ago
|
Updated•19 days ago
|
Updated•19 days ago
|
Assignee | ||
Comment 14•19 days ago
|
||
Since our WebCompat QA folks are already enjoying their weekends, I tested the steps from comment 12 in ESR and Release on Windows and macOS - everything works great!
Jeff will be testing on Linux.
Updated•19 days ago
|
Comment 15•19 days ago
|
||
uplift |
Updated•19 days ago
|
Comment 16•19 days ago
•
|
||
Linux, release and ESR, look good to me.
Assignee | ||
Comment 17•19 days ago
|
||
Update rules for ESR 128, Release 131, and Beta 132 are live. We did not start an update for Nightly 133, as the patch landed yesterday and is already included in today's Nightly.
Unless something goes very horribly wrong (and, I mean, why should an out-of-band update started on Friday at 8pm go wrong?!), I'll consider this done and close this as fixed.
Updated•15 days ago
|
Description
•