1925380 - Clicking (and holding the click) on any of the wallpapers preview in the category header will show a blinking cursor

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Itiel]

Attachment: Screenshot of me clicking and holding the photographs icon. See the cursor on its right side

Comment 1

[Itiel]

This is due to the button being a normal input, not a radio type input.
Adding type=radio to it fixes this but then the following labels gets shifted down by 2-3 pixels.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1881588

:nbarrett, since you are the author of the regressor, bug 1881588, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1881588

Comment 4

[Donal Meehan [:dmeehan]]

:thecount could this be triaged for severity? Wondering if we need something in time for Fx133?

Comment 5

[Scott [:thecount] Downe]

I'm not able to reproduce.

If I click and hold the wallpaper preview, I am not seeing the cursor. I'm trying this on Windows.

Comment 6

[Hanna Jones [:hjones]]

Attachment: Wallpaper item with text entered into the input

Came here to file this same bug, thanks :itiel! Here are my STR which may be helpful for folks investigating:

1. Open the drawer
2. Use the tab key to focus one of the wallpapers
3. Observe the blinking cursor on the inline-start side of the wallpaper input
4. For extra fun, maybe hit the space bar or enter some text into the input

I guess the default behaviour for an input without a specified type is to assume it should behave as type="text", so this is unsurprising. I suspect the lack of a type is also the root cause of bug 1922664.

Comment 7

[Scott [:thecount] Downe]

I can reproduce now, thanks.

For some reason I don't see the cursor if I click and hold, but I do if I tab.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:thecount, could you have a look please?

For more information, please visit BugBot documentation.

Comment 10

[Amy Churchwell [:amy]]

potential good next bug.

Comment 11

[Reem Hamoui]

Working on this ticket now, and imho it's fine that the text under the images move down by a couple of pixels, as it's not disrupting any flow/creating further issues.
I'm also doing a quick a11y test to make sure the sibling of this ticket (https://bugzilla.mozilla.org/show_bug.cgi?id=1922664) will also be solved with this fix. I'll be pushing up the fix for this shortly.

Comment 12

[Reem Hamoui]

Attachment: Bug 1925380 - Fix cursor appearing in New Tab wallpaper selections. r=#home-newtab-reviewers

Comment 13

[Maxx Crawford [:maxx]]

Triage reasoning:

• Severity: -- → S3: Work around exists for this issue
• Priority: -- → P1: Fix in the current release cycle

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d70ffe02f002
Fix cursor appearing in New Tab wallpaper selections. r=home-newtab-reviewers,amy

Comment 15

[amarc]

https://hg.mozilla.org/mozilla-central/rev/d70ffe02f002

Comment 16

[Bogdan Maris, Desktop Test Engineering [Away till 13th July]]

Reproduced the initial issue using an old Nightly build from 2024-09-16, verified that using the latest Nightly 135.0a1 and latest Beta 134.0b1 across platforms (macOS 13, Windows 11 and Ubuntu 22.04) this is fixed.