1925471 - Check for values in PipelineOptions

Status: RESOLVED FIXED

(Core :: Machine Learning: General, enhancement, P3)

Description

[Tarek Ziadé (:tarek)]

We want to add checking logic in PipelineOptions.updateOptions so we don't allow random values when a type is well defined

Comment 1

[Tarek Ziadé (:tarek)]

Attachment: Bug 1925471 - Check for values in PipelineOptions r=vazish

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c30683d926b
Check for values in PipelineOptions r=vazish

Comment 3

[tszentpeteri]

Backed out for causing mochitest failures on browser_MLSuggest_integration.js.

• Backout link
• Push with failures
• Failure Log:

[task 2024-10-24T17:18:03.044Z] 17:18:03     INFO - TEST-START | browser/components/urlbar/tests/browser/browser_MLSuggest_integration.js
[task 2024-10-24T17:18:03.325Z] 17:18:03     INFO - TEST-INFO | started process screentopng
[task 2024-10-24T17:18:03.479Z] 17:18:03     INFO - TEST-INFO | screentopng: exit 0
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - Buffered messages logged at 17:18:03
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - Entering setup bound 
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - Leaving setup bound 
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - Entering test bound test_MLSuggest
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - Buffered messages finished
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_MLSuggest_integration.js | Uncaught exception in test bound test_MLSuggest - at chrome://global/content/ml/EngineProcess.sys.mjs:43 - PipelineOptionsValidationError: Invalid value "text-classification-mozilla/mobilebert-uncased-finetuned-LoRA-intent-classifier" for field "engineId". Should contain only alphanumeric characters, underscores, or dashes.
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - Stack trace:
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - PipelineOptionsValidationError@chrome://global/content/ml/EngineProcess.sys.mjs:43:5
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - #validateTaskName@chrome://global/content/ml/EngineProcess.sys.mjs:309:13
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - updateOptions/<@chrome://global/content/ml/EngineProcess.sys.mjs:438:31
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - updateOptions@chrome://global/content/ml/EngineProcess.sys.mjs:423:17
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - PipelineOptions@chrome://global/content/ml/EngineProcess.sys.mjs:270:10
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - createEngine@chrome://global/content/ml/EngineProcess.sys.mjs:788:27
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - #initializeModelEngine@resource:///modules/urlbar/private/MLSuggest.sys.mjs:138:31
[task 2024-10-24T17:18:03.482Z] 17:18:03     INFO - initialize@resource:///modules/urlbar/private/MLSuggest.sys.mjs:50:34
[task 2024-10-24T17:18:03.483Z] 17:18:03     INFO - test_MLSuggest@chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_MLSuggest_integration.js:220:19
[task 2024-10-24T17:18:03.483Z] 17:18:03     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1145:26
[task 2024-10-24T17:18:03.483Z] 17:18:03     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1217:18
[task 2024-10-24T17:18:03.483Z] 17:18:03     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1358:14
[task 2024-10-24T17:18:03.483Z] 17:18:03     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1134:14
[task 2024-10-24T17:18:03.483Z] 17:18:03     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-10-24T17:18:03.483Z] 17:18:03     INFO - Leaving test bound test_MLSuggest
[task 2024-10-24T17:18:03.483Z] 17:18:03     INFO - Closing the view directly
[task 2024-10-24T17:18:03.483Z] 17:18:03     INFO - Waiting for the view to close
[task 2024-10-24T17:18:03.483Z] 17:18:03     INFO - Urlbar view closed
[task 2024-10-24T17:18:03.483Z] 17:18:03     INFO - GECKO(1057) | [Child 1303, Main Thread] WARNING: 'presShell->NeedLayoutFlush()', file /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:2210
[task 2024-10-24T17:18:03.863Z] 17:18:03     INFO - GECKO(1057) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmp8elcmt5n.mozrunner/runtests_leaks_tab_pid1365.log
[task 2024-10-24T17:18:03.882Z] 17:18:03     INFO - GECKO(1057) | [Child 1365, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:757
[task 2024-10-24T17:18:03.968Z] 17:18:03     INFO - GECKO(1057) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2024-10-24T17:18:03.969Z] 17:18:03     INFO - GECKO(1057) | MEMORY STAT | vsize 11380MB | residentFast 472MB | heapAllocated 250MB
[task 2024-10-24T17:18:03.969Z] 17:18:03     INFO - TEST-OK | browser/components/urlbar/tests/browser/browser_MLSuggest_integration.js | took 925ms
[task 2024-10-24T17:18:03.982Z] 17:18:03     INFO - GECKO(1057) | [Child 1180: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f475ee71800 == 2 [pid = 1180] [id = 1]
[task 2024-10-24T17:18:03.982Z] 17:18:03     INFO - GECKO(1057) | [Child 1180: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (7f475e536600) [pid = 1180] [serial = 5] [outer = 0]
[task 2024-10-24T17:18:03.982Z] 17:18:03     INFO - GECKO(1057) | [Child 1180: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (7f475ee72400) [pid = 1180] [serial = 6] [outer = 7f475e536600]
[task 2024-10-24T17:18:04.018Z] 17:18:04     INFO - checking window state
[task 2024-10-24T17:18:04.039Z] 17:18:04     INFO - TEST-START | browser/components/urlbar/tests/browser/browser_UrlbarInput_formatValue.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70be2e2c7b5c
Check for values in PipelineOptions r=vazish,urlbar-reviewers,adw

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/70be2e2c7b5c

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 9432037 [details]
Bug 1925471 - Check for values in PipelineOptions r=vazish

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: This is required for Yelp ML suggestions in the address bar, which we want to experiment with in 133.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): These are some plumbing fixes that aren't user-visible.
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9432037 [details]
Bug 1925471 - Check for values in PipelineOptions r=vazish

Approved for 133.0b5

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/fc503c12d97e