1925572 - [css-color] Optimize validation of parsed color functions for relative colors.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Tiaan Louw [:tlouw]]

Right now we are checking for a valid ColorFunction after the whole color was parsed. This can be improved by checking for the allowed components (r, g, b, h, s, l, a, b, alpha, etc.) when parsing a leaf node in calc and also checking whether the calc nodes have valid units, e.g. color channel keywords always resolve to numbers and can't be added to degrees or some other unit.

Comment 1

[Sajid Anwar [:sajidanwar]]

Attachment: Bug 1925572 - Improve parsing and validation of channel keywords in relative colors. r=#style

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ebc67fe1ae3a
https://hg.mozilla.org/integration/autoland/rev/45c32fcdf248
Improve parsing and validation of channel keywords in relative colors. r=firefox-style-system-reviewers,tlouw,emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fac7ee2b1285
https://hg.mozilla.org/integration/autoland/rev/075d9b59cd91
Revert "Bug 1925572 - Improve parsing and validation of channel keywords in relative colors. r=firefox-style-system-reviewers,tlouw,emilio" for causing flag related failures.

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing flag related failures.

Push with failures

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=572722404&repo=autoland&task=ajXsYkX-SpekyPHALa1T8w.0
• https://treeherder.mozilla.org/logviewer?job_id=572722422&repo=autoland&task=b3xeFi5MRVO4oTkRz5l45Q.0

Backout link

Comment 5

[Sajid Anwar [:sajidanwar]]

Thanks, very silly typo, should have caught the failing build on Phabricator. Will be pushing an update shortly.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9302a5cf43db
https://hg.mozilla.org/integration/autoland/rev/1b7357f55ca1
Improve parsing and validation of channel keywords in relative colors. r=firefox-style-system-reviewers,tlouw,emilio

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1b7357f55ca1