Closed Bug 1925607 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 48699 - Improve select-parsing test readability

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48699 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48699
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Improve select-parsing test readability

It was recommended here to use trim() to make these test cases more
readable:
https://chromium-review.googlesource.com/c/chromium/src/+/5936092/comment/051341cb_4c94e057/

Change-Id: I532b08bef1a7f04e4be3325d2ed3769d7ed564b9

Reviewed-on: https://chromium-review.googlesource.com/5939523
WPT-Export-Revision: 8cc9b714013abe8ecb1978375fc9a00d2d99460f

PR 48699 applied with additional changes from upstream: 00e1df7e329f3d11b91d7b2e11a2db63bbd98ef9
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 7

Chrome

OK : 1
PASS: 8

Safari

OK : 1
PASS: 1
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/forms/the-select-element/customizable-select/select-parsing.tentative.html [wpt.fyi]
    • <div>s, <button>s, and <datalist>s should be allowed in <select>.: FAIL (Chrome: PASS, Safari: FAIL)
    • </select> should close <button>.: FAIL (Chrome: PASS, Safari: FAIL)
    • </select> should close <datalist>.: FAIL (Chrome: PASS, Safari: FAIL)
    • <select> in <button> in <select> should remove inner <select>.: FAIL (Chrome: PASS, Safari: FAIL)
    • <select> in <select><button><div> should remove inner <select>.: FAIL (Chrome: PASS, Safari: FAIL)
    • Divs and imgs should be allowed as direct children of select and within options without a datalist.: FAIL (Chrome: PASS, Safari: FAIL)
    • Input tags should parse inside select instead of closing the select.: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2bbbd5f794ec [wpt PR 48699] - Improve select-parsing test readability, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.