1926031 - clean up selection scrollIntoView native callers

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1926031 - Fix whitespace in nsISelectionController.idl. r=jjaschke,masayuki

The mix of 2, 3, and 4-space indent really was throwing me off.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1926031 - Remove unused NS_ISELECTIONCONTROLLER_CID. r=jjaschke,masayuki

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1926031 - Use a cenum for selection controller scroll flags. r=jjaschke,masayuki

Note that the casts are ugly but they will go away sooner rather than
later.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1926031 - Remove unused SCROLL_FOR_CARET_MOVE. r=jjaschke,masayuki

No point in keeping the code around.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1926031 - Use the actual flags to define ScrollFlags::AnchorScrollFlags. r=jjaschke,masayuki

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1926031 - Make Selection::ScrollIntoView take ScrollFlags. r=jjaschke,masayuki

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1926031 - Add a more c++-friendly nsISelectionController::ScrollSelectionIntoView. r=jjaschke,masayuki

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59dfc493f109
Fix whitespace in nsISelectionController.idl. r=jjaschke,masayuki
https://hg.mozilla.org/integration/autoland/rev/036afe7c5b49
Remove unused NS_ISELECTIONCONTROLLER_CID. r=jjaschke,masayuki

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9531eaa37dc2
Use the actual flags to define ScrollFlags::AnchorScrollFlags. r=jjaschke,masayuki

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/525527d1b275
Use a cenum for selection controller scroll flags. r=jjaschke,masayuki
https://hg.mozilla.org/integration/autoland/rev/517a92aa9abc
Remove unused SCROLL_FOR_CARET_MOVE. r=jjaschke,masayuki
https://hg.mozilla.org/integration/autoland/rev/32246e2df565
apply code formatting via Lando

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c68a7cef14a
Make Selection::ScrollIntoView take ScrollFlags. r=jjaschke,masayuki
https://hg.mozilla.org/integration/autoland/rev/0ea5694ab077
Add a more c++-friendly nsISelectionController::ScrollSelectionIntoView. r=jjaschke,masayuki

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/59dfc493f109
https://hg.mozilla.org/mozilla-central/rev/036afe7c5b49
https://hg.mozilla.org/mozilla-central/rev/9531eaa37dc2
https://hg.mozilla.org/mozilla-central/rev/525527d1b275
https://hg.mozilla.org/mozilla-central/rev/517a92aa9abc
https://hg.mozilla.org/mozilla-central/rev/32246e2df565
https://hg.mozilla.org/mozilla-central/rev/5c68a7cef14a
https://hg.mozilla.org/mozilla-central/rev/0ea5694ab077

Comment 13

[Geoff Lankow (:darktrojan) [OOO, back 21 July]]

FYI, while looking into this I found a bunch of JS callers still using true as the third argument, which I guess works, but doesn't feel right.