1926119 - Remove an extra paragraph from the History sidebar panel empty state

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Ania]

Attachment: actual result.png

STRs

1. Activate sidebar in the Labs, set Nightly to Never remember history settings and clear history.
2. Open History panel.

Actual result

1. There's an extra (second) paragraph with the old strings for this state, after the correct new strings (title and first paragraph).

Expected result

1. The text ends after the first paragraph (please see screenshot).

Comment 1

[Ania]

Attachment: expected result.png

Comment 2

[Stuart Colville [:muffinresearch]]

Attachment: Bug 1926119: Remove 2nd empty-state string for don't remember history. r=#sidebar-reviewers

Comment 3

[Stuart Colville [:muffinresearch]]

What happened here was the first string was updated in bug 1911749 but the 2nd string left as in it's original form. The update of the first string made it similar to the 2nd string so now there's what looks like duplication which was overlooked during the update.

The quick solution here is to remove the 2nd string entirely as it's no longer needed.

QA Notes:

This is also visible in Fx View, recent browsing, recently closed and history as well as the history sidebar with "Never remember history". The patch has before and after screenshots.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cefead3e5fd3
Remove 2nd empty-state string for don't remember history. r=sidebar-reviewers,fluent-reviewers,fxview-reviewers,sclements

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/cefead3e5fd3