1926193 - Update android nightly application-services version bump to new version a0121f35125bd61ebd10fab969f6cfcc02f94d5a from 2024-10-22 05:04:02

Status: RESOLVED FIXED

(Firefox for Android :: Search, enhancement)

Description

[Update Bot]

This update covers 4 commits, including 1 new upstream commit I've never filed a bug on before. (It's the top one.). Here are the overall diff statistics, and then the commit information.

---

mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

a0121f35125bd61ebd10fab969f6cfcc02f94d5a by Drew Willcoxon <[e-mail]>

https://github.com/mozilla/application-services/commit/a0121f35125bd61ebd10fab969f6cfcc02f94d5a
Authored: 2024-10-18 16:59:36 -0700
Committed: 2024-10-21 18:57:47 +0000

Add country to weather suggestions

I just saw that Merino expects a country to be passed along with city and region
in weather requests. Rather than assuming "US" and hardcoding that in desktop,
which would be fine for now, let's just go ahead and add the matching geoname's
country code to Suggestion::Weather. It's a small change.

This doesn't modify query parsing at all. Country names still aren't supported
in queries. We can cross that bridge if/when we come to it.

Files Modified:

• components/suggest/src/suggestion.rs
• components/suggest/src/weather.rs

---

23618bbad9204fec25fc09e2db7921c0cfc6ea84 by Ben Dean-Kawamura <[e-mail]>

https://github.com/mozilla/application-services/commit/23618bbad9204fec25fc09e2db7921c0cfc6ea84
Authored: 2024-10-21 11:13:51 -0400
Committed: 2024-10-21 15:58:18 +0000

Bug 1925601 - Fix the iOS build (again)

The last hack didn't fix the iOS build. I looked through xcframework
zip from the nightly build artifacts
(https://firefoxci.taskcluster-artifacts.net/dHGArzP3R0Cmwcr56RPQJA/0/public/build/nightly.json)
and it seems like it was correctly copying the RustViaductFFI.h file,
but not correctly updating module.modulemap.

The main issue was the awk command was printing out the updated
contents to STDOUT, but not actually modifying module.modulemap. I
fixed that and also moved away from awk, since I'm worried about
differences between gawk and nawk.

Files Modified:

• megazords/ios-rust/generate-files.sh

---

6e93be391341bff0b601d02d421318684b1532d9 by Ben Dean-Kawamura <[e-mail]>

https://github.com/mozilla/application-services/commit/6e93be391341bff0b601d02d421318684b1532d9
Authored: 2024-10-08 17:03:39 -0400
Committed: 2024-10-21 13:33:37 +0000

Bug 1910381 - Switch Remote Settings to proc-macros

Tested this by running the following commands and diffing the generated
code from before this change:

cargo build --release -p megazord
cargo uniffi-bindgen generate --library target/release/libmegazord.so --crate remote_settings --language kotlin --out-dir [out-dir]

There were a few differences:
- The field order for RemoteSettingsConfig changed
- Some docstrings were missing
- Some of the method parameter names changed

To fix this, I updated the Rust code to match the deleted UDL file.

Files Deleted:

• components/remote_settings/build.rs
• components/remote_settings/src/remote_settings.udl

Files Modified:

• components/nimbus/src/nimbus.udl
• components/remote_settings/src/client.rs
• components/remote_settings/src/config.rs
• components/remote_settings/src/error.rs
• components/remote_settings/src/lib.rs
• components/suggest/src/lib.rs
• megazords/ios-rust/MozillaTestServices/MozillaTestServices.xcodeproj/project.pbxproj

---

a23f3adce2783f0df8b0775762c1decaeaf8adad by Ben Dean-Kawamura <[e-mail]>

https://github.com/mozilla/application-services/commit/a23f3adce2783f0df8b0775762c1decaeaf8adad
Authored: 2024-10-18 16:36:27 -0400
Committed: 2024-10-21 13:20:33 +0000

Bug 1925601 - Fix the iOS build

We need to hack it to add the Viaduct header, since that component
doesn't use UniFFI.

Files Modified:

• megazords/ios-rust/generate-files.sh

---

Comment 2

[Update Bot]

Updatebot has encountered an unknown error and does not know how to further
process this library update. Please review and take manual action for this update.

The Updatebot maintainers have been notified and Updatebot will no longer process
this update.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Search' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Donal Meehan [:dmeehan]]

Attachment: Bug 1926193 - Update android nightly application-services version bump to a0121f35125bd61ebd10fab969f6cfcc02f94d5a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec787687e9db
Update android nightly application-services version bump to a0121f35125bd61ebd10fab969f6cfcc02f94d5a r=release-managers,diannaS

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/ec787687e9db