192629 - Certain GIF is printed in white on black bottom with PCL 5

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Lee Tartak]

This is a continuation of bug 158472. The fix for that bug took care of all
situations except for Laserjet in non PCL6 mode. If the Laserjet driver is set
to PCL6 or printer specific in any case the image prints correctly.  This is an
OS2 bug only.  Will attach image below.

Comment 1

[Lee Tartak]

Attachment: A gif that shows the problem

Comment 2

[Lee Tartak]

Attachment: Patch to fix problem

As part of  processing the image the code creates a temp bitmap in a memory DC.
 The bitmap was created with a color depth of 8 BPP.  In this color depth the
GPI erase filled the background with BLACK for laserjet non PCL6 modes For all
other devices and printer compatible PSs WHITE	is used.  However when the temp
bitmap color depth is set to 24 BPP when creating the background is WHITE as it
should. Since all the printer DCs can handle 24 BPP is better to work in
thatdepth anyway.

Comment 3

[Lee Tartak]

Attachment: New patch to fix problem

Old patch did not work with optimized code.

Comment 4

[Mike Kaply [:mkaply]]

taking

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 120109 [details] [diff] [review]
New patch to fix problem

r=mkaply, sr=blizzard, a=mkaply

Comment 6

[Mike Kaply [:mkaply]]

Fixed on trunk and 1.4