1926394 - No animation when dragging a tab over other tabs in a tab group

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Amy Lee [:amylee] UX]

Attachment: no animation.mov

Steps to reproduce

Create a tab group with 1+ tabs inside
Open several new tabs outside the tab group
Drag a tab into the tab group

Expected
There is a sliding animation when you drag a tab inside a tab group (same as when you move a tab when not in a group)

Actual
No sliding animation when moving a tab inside a group

See screen recording

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1926394 - Update [movingtab] selectors to account for grouped tabs. r?jswinarton,dwalker,sthompson

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79c92abcd174
Update [movingtab] selectors to account for grouped tabs. r=dwalker,tabbrowser-reviewers

Comment 3

[Dão Gottwald [:dao]]

Tagging Amy to review this in the next Nightly build after this bug gets resolved.

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_preserveTabPipIconOverlay.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_preserveTabPipIconOverlay.js | Test timed out -

Also please check these mochitests failures, these mochitests failures and these mochitests failures.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ae61137c8c5
Update [movingtab] selectors to account for grouped tabs. r=jswinarton,dwalker,tabbrowser-reviewers

Comment 6

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/9ae61137c8c5

Comment 7

[Amy Lee [:amylee] UX]

Looks good. Thanks!

Comment 8

[Ada C.]

I was able to reproduce the issue on Win10x64 using Firefox build 133.0a1 (2024-10-22).
Verified as fixed on Win10x64, macOS 13.6 ARM and Ubuntu 24.04 using Firefox build 134.0a1 and 133.0b9.