Closed Bug 1926476 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 48766 - Bump maximum video frame size by one bit.

Categories

(Core :: Audio/Video: Web Codecs, task, P4)

task

Tracking

()

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48766 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48766
Details from upstream follow.

Dale Curtis <dalecurtis@chromium.org> wrote:

Bump maximum video frame size by one bit.

This increases the maximum canvas size from 268,435,456 or roughly
16384x16384 to 536,870,911 or roughly 23170x23170. This increase
still allows us to represent up to 8 bytes per pixel (which matches
our largest pixel formats) without overflowing a uint32_t.

This also updates the file to use inline constexpr per the
presubmit check and adds tests for these allocation limits.

Fixed: 374807001
Change-Id: I7eef8b488fa758bfcd0202917469d585724e23ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5955549
Commit-Queue: Eugene Zemtsov \<eugene@chromium.org>
Auto-Submit: Dale Curtis \<dalecurtis@chromium.org>
Reviewed-by: Eugene Zemtsov \<eugene@chromium.org>
Commit-Queue: Dale Curtis \<dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1372466}

Component: web-platform-tests → Audio/Video: Web Codecs
Product: Testing → Core

CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 41 subtests

Status Summary

Firefox

OK : 2
PASS : 80[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 82[Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]
PRECONDITION_FAILED: 2

Chrome

OK : 2
PASS : 78
FAIL : 4

Safari

OK : 2
PASS : 78
FAIL : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /webcodecs/video-encoder-config.https.any.html [wpt.fyi]
    • VideoEncoder.isConfigSupported() supports:{"codec":"avc1.42001E","hardwareAcceleration":"no-preference","width":640,"height":480,"bitrate":5000000,"framerate":24,"avc":{"format":"annexb"},"futureConfigFeature":"foo"}: PASS [Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], PRECONDITION_FAILED [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: PASS, Safari: PASS)
  • /webcodecs/video-encoder-config.https.any.worker.html [wpt.fyi]
    • VideoEncoder.isConfigSupported() supports:{"codec":"avc1.42001E","hardwareAcceleration":"no-preference","width":640,"height":480,"bitrate":5000000,"framerate":24,"avc":{"format":"annexb"},"futureConfigFeature":"foo"}: PASS [Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], PRECONDITION_FAILED [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/46ee7a982959 [wpt PR 48766] - Bump maximum video frame size by one bit., a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.