1926647 - With new sidebar enabled, opening private windows always have the sidebar expanded.

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Stuart Colville [:muffinresearch]]

Attachment: Screenshot 2024-10-23 at 18.13.27.png

• With the new sidebar enabled (with or without vertical tabs)
• Open a new private window
• The private window always opens with the sidebar expanded.

This was noted on connect as well.

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1926647 - With new sidebar enabled, opening private windows always have the sidebar expanded. r?#sidebar-reviewers

• Ensure that we don't load the backup state if a private window was spawned from a non-private one.
• Ensure that undefined values (i.e. missing backup state properties) are not used to set UI state.
• Remove setup functions that "pushed" existing tests to pass, as these concealed a real issue.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e12f9e4708c1
With new sidebar enabled, opening private windows always have the sidebar expanded. r=sidebar-reviewers,sclements

Comment 3

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/e12f9e4708c1

Comment 4

[Ada C.]

I was able to reproduce the issue on Win10x64 using Firefox build 133.0a1 (2024-10-23).
Verified as fixed on Win10x64, macOS 13.6 ARM and Ubuntu 24.04 using Firefox build 134.0a1 and 133.0b9.