Closed Bug 1926741 Opened 9 months ago Closed 9 months ago

Perma [tier 2] test_pdf_download | AssertionError('Mismatching screenshots for test_pdf_download_base_2404.png with extremas: ((0, 255), (0, 255), (0, 255))')

Categories

(Firefox Build System :: Third Party Packaging, defect, P5)

Product:
Firefox Build System
Component:
Third Party Packaging
Type:
defect

Tracking

(firefox133 fixed)

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox133 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: gerard-majax)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1926741 - Update Snap PDF references to match PDF.js changes on stable channel r?benchatt!
48 bytes, text/x-phabricator-request
Details | Review

Filed by: nfay [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=479594019&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/GhuqhoWYRWWElk6HXQSwzg/runs/0/artifacts/public/logs/live_backing.log

[task 2024-10-24T00:50:36.492Z] TEST-START | test_pdf_download
[task 2024-10-24T00:51:42.397Z] Wait for consent form: timed out, maybe it is not here
[task 2024-10-24T00:51:53.557Z] Non empty differences bbox: (144, 0, 1042, 894)
[task 2024-10-24T00:51:53.665Z] Saving screenshot 'screenshot_test_pdf_download_fail.png' to '/home/task_172973079810143/builds/worker/artifacts/screenshot_test_pdf_download_fail.png'
[task 2024-10-24T00:51:53.764Z] Saving screenshot 'screenshot_test_pdf_download_fail_parent.png' to '/home/task_172973079810143/builds/worker/artifacts/screenshot_test_pdf_download_fail_parent.png'
[task 2024-10-24T00:51:53.903Z] TEST-UNEXPECTED-FAIL | test_pdf_download | AssertionError('Mismatching screenshots for test_pdf_download_base_2404.png with extremas: ((0, 255), (0, 255), (0, 255))')
[task 2024-10-24T00:51:53.903Z] TEST-INFO took 77412ms
[task 2024-10-24T00:51:53.904Z] Traceback (most recent call last):
[task 2024-10-24T00:51:53.904Z]   File "/home/task_172973079810143/fetches/basic_tests.py", line 99, in __init__
[task 2024-10-24T00:51:53.904Z]     rv = getattr(self, m)(expectations)
[task 2024-10-24T00:51:53.904Z]          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-10-24T00:51:53.904Z]   File "/home/task_172973079810143/fetches/qa_tests.py", line 566, in test_pdf_download
[task 2024-10-24T00:51:53.904Z]     self.assert_rendering(exp, self._driver)
[task 2024-10-24T00:51:53.904Z]   File "/home/task_172973079810143/fetches/basic_tests.py", line 306, in assert_rendering
[task 2024-10-24T00:51:53.904Z]     min_is_black and max_is_low_enough
[task 2024-10-24T00:51:53.904Z] AssertionError: Mismatching screenshots for test_pdf_download_base_2404.png with extremas: ((0, 255), (0, 255), (0, 255))
[task 2024-10-24T00:51:53.907Z] tabs_after EXCEPTION {'3d64fd47-37dd-4ce1-9e17-dc447cd3b724', '5f4cf3c7-d0ea-4f5a-ba88-6dae49b4d032'}
[task 2024-10-24T00:51:53.908Z] tabs_before {'3d64fd47-37dd-4ce1-9e17-dc447cd3b724'}
[task 2024-10-24T00:51:53.908Z] opened 1 tabs
[task 2024-10-24T00:51:53.908Z] opened {'5f4cf3c7-d0ea-4f5a-ba88-6dae49b4d032'} tabs
[task 2024-10-24T00:51:53.908Z] switch to 5f4cf3c7-d0ea-4f5a-ba88-6dae49b4d032
[task 2024-10-24T00:51:53.911Z] close 5f4cf3c7-d0ea-4f5a-ba88-6dae49b4d032
[task 2024-10-24T00:51:54.040Z] wait EC.number_of_windows_to_be(1)
[task 2024-10-24T00:51:54.055Z] TEST-START | test_pdf_navigation
Flags: needinfo?(lissyx+mozillians)
Assignee: nobody → lissyx+mozillians
Flags: needinfo?(lissyx+mozillians)

From the screenshot, toolbar buttons seems to not match and in mozilla-release pushes from a few days ago https://hg.mozilla.org/releases/mozilla-release/pushloghtml?changeset=0e15e2edd460163e40ac3ca3cb29ff48cfbc3967 there's https://bugzilla.mozilla.org/show_bug.cgi?id=1921071 :

#18784 Remove duplicated --toolbar-height definition in the css
#18786 Increase the size of the toolbar depending on the uidensity (bug 1171799)

So I suspect we just need to update screenshots because of that PDF.js change

Component: Task Configuration → Third Party Packaging

(In reply to :gerard-majax from comment #1)

From the screenshot, toolbar buttons seems to not match and in mozilla-release pushes from a few days ago https://hg.mozilla.org/releases/mozilla-release/pushloghtml?changeset=0e15e2edd460163e40ac3ca3cb29ff48cfbc3967 there's https://bugzilla.mozilla.org/show_bug.cgi?id=1921071 :

#18784 Remove duplicated --toolbar-height definition in the css
#18786 Increase the size of the toolbar depending on the uidensity (bug 1171799)

So I suspect we just need to update screenshots because of that PDF.js change

https://treeherder.mozilla.org/jobs?repo=try&revision=07e4a330cfa3f787402c1d8e69e77796c42faf26

PDF.js on release got updated with changes to the toolbar buttons, so we
need to update our screenshots to match.

Pushed by alissy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a4e8ce398345 Update Snap PDF references to match PDF.js changes on stable channel r=benchatt

https://hg.mozilla.org/mozilla-central/rev/a4e8ce398345

Status: NEW → RESOLVED
Closed: 9 months ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: