1926981 - 4.73 - 2.02% pdfpaint xfa_issue14315.pdf / pdfpaint tiling-pattern-box.pdf + 64 more (Linux) regression on Thu October 17 2024

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Treeherder Bug Filer]

Perfherder has detected a talos performance regression from push df020056819341b4115a98713ce4585d60eb8252. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
5%	pdfpaint xfa_issue14315.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	269.26 -> 281.99
4%	pdfpaint xfa_bug1717681.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	606.90 -> 631.84
4%	pdfpaint issue18138.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	478.86 -> 498.22
4%	pdfpaint issue2853.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	423.13 -> 439.40
4%	pdfpaint xfa_bug1722038.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	538.11 -> 558.31
4%	pdfpaint sizes.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	256.72 -> 265.79
4%	pdfpaint xfa_bug1717668_2.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	614.48 -> 636.05
3%	pdfpaint xfa_issue13584.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	605.02 -> 625.24
3%	pdfpaint xfa_bug1716380.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	560.96 -> 579.30
3%	pdfpaint xfa_issue13597.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	606.51 -> 626.36
...	...	...	...	...
2%	pdfpaint xfa_bug1718053.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	767.66 -> 784.28
2%	pdfpaint annotation-as.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	703.36 -> 717.99
2%	pdfpaint xfa_bug1716980.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	2,900.48 -> 2,959.40
2%	pdfpaint issue5567.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	816.70 -> 833.17
2%	pdfpaint tiling-pattern-box.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	1,971.40 -> 2,011.30

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 2542

The following documentation link provides more information about this command.

For more information on performance sheriffing please see our FAQ.

If you have any questions, please do not hesitate to reach out to [e-mail].

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1925258

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1925258

Comment 3

[BugBot [:suhaib / :marco]]

It has been over 7 days with no activity on this performance regression.
:dao, since you are the author of the regressor, bug 1925258, which triggered this performance alert, could you please provide a progress update?

If you need additional information/help, please needinfo the performance sheriff who filed this alert (they can be found in comment #0), or reach out in #perftest, or #perfsheriffs on Element.

For more information, please visit BugBot documentation.

Comment 4

[Calixte Denizet (:calixte)]

Most of the regressions are only for very specific kind of pdfs (XFA) which are rendered with a lot of HTML elements.
I don't really understand the link between the regressions and the patch, but I'd happy to know and if there's something we can do to improve, please tell me.
So from my perspective, it's completely fine to keep the patch.

Comment 5

[Donal Meehan [:dmeehan]]

Setting Fx133 and F134 to fixed, the regressor was backed out of both central and beta
https://bugzilla.mozilla.org/show_bug.cgi?id=1925258#c4
https://bugzilla.mozilla.org/show_bug.cgi?id=1925258#c5

Comment 6

[Dão Gottwald [:dao]]

(In reply to Calixte Denizet (:calixte) from comment #4)

Most of the regressions are only for very specific kind of pdfs (XFA) which are rendered with a lot of HTML elements.
I don't really understand the link between the regressions and the patch, but I'd happy to know and if there's something we can do to improve, please tell me.
So from my perspective, it's completely fine to keep the patch.

There's bug 1927120 too, so I won't attempt to reland the patch.