192703 - Show custom application icons in start menu (main and group) and quick launch

Status: RESOLVED INCOMPLETE

(SeaMonkey :: Installer, enhancement)

Description

[Alexander Papaspyrou]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030210 WebWasher 3.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030210 WebWasher 3.3

It would be nice if the app shortcuts in the start menu (both in the group and
in the "Internet" and "Mail" part of the Windows XP enhanced start menu would
use the specific application's icon instead of the standard lizard.

Reproducible: Always

Steps to Reproduce:
1. install Mozilla

Actual Results:  
Every Mozilla app uses the standard lizard icon (mozilla.exe,0)

Expected Results:  
Every Mozilla app should use it's own icon from "chrome/icons/default/*".

This is quite easy to fix. When creating the registry keys for the icons, all we
have to do is to place the icon path into the configuration:

Replace
   "<pathToMozilla>\mozilla.exe,0"
by
   "<pathToMozilla>\chrome\icons\default\<appropriateAppIconFile>".

That's all, folks.

Comment 1

[Brian 'netdragon' Bober]

This is a dupe.

Comment 2

[Brian 'netdragon' Bober]

Dupe of bug 162935 or bug 162858?

Comment 3

[Brian 'netdragon' Bober]

*** Bug 162935 has been marked as a duplicate of this bug. ***

Comment 4

[Brian 'netdragon' Bober]

Note this is not only a Windows XP problem because it refers to the Start Menu.

This might still be a dupe of some bug.

Comment 5

[Alexander Papaspyrou]

Sorry, I didn't find the denoted bugs when doing a search before submitting. But
I have two annotations to this bug:

1.
I'm not sure if the patch from bug 162858 made it into the 1.3 trunk -- after
installing it, the created shortcuts all displayed the lizard. Can anyone
confirm this?

2.
This issue has not been fixed for the "Mozilla" (aka browser) shortcut; line <a
href="http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/windows/browser.jst#310">310</a>
is still incorrect.

Regards,
Alexander

Comment 6

[Eglė K]

It is hard to fix this bug ? Now is very hard to start mozilla mail for most
users, because browser and mail has same icons :(

Comment 7

[Stefan Borggraefe]

*** Bug 195372 has been marked as a duplicate of this bug. ***

Comment 8

[Brian 'netdragon' Bober]

I'm fixing this.

Comment 9

[Brian 'netdragon' Bober]

- mail.jst and browser.jst have almost the same code in createShortcuts() -
refactor?

- editor.jst, venkman.jst and chatzilla.jst also need similiar code.

- palmsync needs to have icons in the install program to use.

- addressbook needed in mail.jst

- profile icon needs hooking up

Comment 10

[Brian 'netdragon' Bober]

ssu mentioned that i should just copy the createShortcuts() function for now to
all of the other .jst files. The refactoring is another bug.

Comment 11

[Brian 'netdragon' Bober]

Bug 72254 is being marked WONTFIX because I am bringing back the Uninstall 
start menu item, along with adding address book, profile manager, etc. They 
will all appear within a "Mozilla Tools" directory about "Mozilla PalmSync" as 
not to clutter up the start menu.

Comment 12

[Serge Gautherie (:sgautherie)]

(Brian)
Can you check my bug 172537 comment 5 (and 3) ?
I feel that it could be related to the current bug, maybe with a dependency or
duplicate relation.

Comment 13

[Brian 'netdragon' Bober]

Its dependant, yes. You can use my profile manager icon once its checked in.

Comment 14

[Brian 'netdragon' Bober]

See also: Bug 199576 about inconsistant icon naming.

Comment 15

[Brian 'netdragon' Bober]

*** Bug 162347 has been marked as a duplicate of this bug. ***

Comment 16

[Raoul Nakhmanson-Kulish]

Still persists in Seamonkey 1.0

Suggestion: this may be fixed by adding two strings in the Windows registry:

!!!!! BE AWARE! EDIT STRINGS ACCORDING YOUR SEAMONKEY DIRECTORY !!!!!

[HKEY_LOCAL_MACHINE\SOFTWARE\Clients\StartMenuInternet\seamonkey.exe\DefaultIcon]
@="C:\\PROGRA~1\\mozilla.org\\SeaMonkey\\chrome\\icons\\default\\main-window.ico,0"

[HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\SeaMonkey\.eml\DefaultIcon]
@="C:\\PROGRA~1\\mozilla.org\\SeaMonkey\\chrome\\icons\\default\\messenger-window.ico,0"

Also I would suggest these registry keys to call Preferences and Account settings dialog from Start Menu by right-clicking on Seamnokey mail icon:

[HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\SeaMonkey\shell\preferences]
@="P&references"

[HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\SeaMonkey\shell\preferences\command]
@="C:\\PROGRA~1\\mozilla.org\\SeaMonkey\\seamonkey.exe -chrome \"chrome://communicator/content/pref/pref.xul\""

[HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\SeaMonkey\shell\properties]
@="&Account Settings"

[HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\SeaMonkey\shell\properties\command]
@="C:\\PROGRA~1\\mozilla.org\\SeaMonkey\\seamonkey.exe -chrome \"chrome://messenger/content/AccountManager.xul\""

Comment 17

[Raoul Nakhmanson-Kulish]

Sorry, instead of
[HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\SeaMonkey\.eml\DefaultIcon]

must be
[HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\SeaMonkey\DefaultIcon]

Comment 18

[Robert Kaiser]

Old XPFE installer is dead now with the end of life for SeaMonkey 1.x, and I think this has been solved in the SeaMonkey 2 world.