1927099 - Warning or blocked dialog will be triggered for each file even if the files should be allowed if the folder name implies that

Status: RESOLVED INVALID

(Firefox :: Data Loss Prevention, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 31 Aug- 11 Sep, please ni? :mboldan]]

Attachment: foldername.gif

Found in

• 133.0a1 (2024-10-24)

Affected versions

• 133.0a1 (2024-10-24)

Tested platforms

• Affected platforms: Windows 11, Windows 10
• Unaffected platforms:macOS 12, Ubuntu

Preconditions

• Download the DLP test assets from https://drive.google.com/file/d/1yjqVRuxdKV3WnO7D2wzMgDXBuYBxUgVw/view
• Create a distribution folder inside the Firefox folder and paste the policies-2.json to it and then rename it to policies.json
• run the DLP agent in CMD using: .\content_analysis_sdk_agent.exe --user --toblock=.\d{3}-?\d{2}-?\d{4}. --towarn=.warn. --delays=10
• A folder named warn/123456789 created that contains allowed files.

Steps to reproduce

1. Open https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/webkitdirectory
2. Drag and drop the folder from the preconditions over the Browser button from the Examples section.

Expected result

• File upload is permitted.

Actual result

• Warning dialog /Blocked dialog is displayed for each file.

Regression range

• This happens after bug 1919752 and bug 1915351. Before 1915351 the warning dialog was only displayed once but the upload will not work. Setting bug 1915351 as the regressor since this behavior was introduced after this issue.

Additional notes

• Attached a screen recording.

Comment 1

[BugBot [:suhaib / :marco]]

:gstoll, since you are the author of the regressor, bug 1915351, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Greg Stoll :gstoll]

I'll have to think about this a little more, but I think this might be correct behavior - the DLP agent we're using for testing just examines the path, so it will return WARN/BLOCK for each one of these files.

Comment 3

[Donal Meehan [:dmeehan]]

Setting Fx133 to fixed since the regressor was backed out
https://bugzilla.mozilla.org/show_bug.cgi?id=1915351#c23

Comment 4

[Greg Stoll :gstoll]

Yeah, this is the expected behavior when there are multiple WARN results.

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 31 Aug- 11 Sep, please ni? :mboldan]]

(In reply to Greg Stoll :gstoll from comment #4)

Yeah, this is the expected behavior when there are multiple WARN results.

Hello Greg! Just to make sure we understand this correctly, if we have a folder named warning and the contents of the folder are 123.txt and 345.txt, will the warning dialog be displayed for 123.txt and for 345.txt even if the file names are not part of *warn? Thank you in advance!

Comment 6

[Greg Stoll :gstoll]

Yes, that's correct. The sample DLP agent analyzes the whole path of the file, so any file in the warning directory will get a WARN result.