1927258 - Vertical pinned tabs should have a fade affect when tabs overflow

Status: RESOLVED FIXED

(Firefox :: Sidebar, enhancement, P2)

Description

[Alan Cartledge]

Attachment: Vertical Tabs.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:133.0) Gecko/20100101 Firefox/133.0

Steps to reproduce:

Restarted Nightly (133.0a1 (2024-10-25) (32-bit)) issue persists

Actual results:

Last pinned vertical tab dies not display correctly, it is "chopped in half"

Expected results:

Display correctly

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Sidebar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Sarah Clements [:sclements]]

You can scroll the tabs when they overflow the pinned tabs area - that's what is happening there. We need to add a fade would should help to indicate you can scroll there.

Comment 3

[Ina Popescu, Desktop QA]

Thank you for the insights provided. I’m updating the type to enhancement based on Comment 2 and setting the status to New.

Comment 4

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1927258 - Add a fade effect when vertical pinned tabs overflow r=#sidebar-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85d499c8e0bf
Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab543854c3d8
Backed out changeset 85d499c8e0bf for causing multiple failures tabbrowser related. CLOSED TREE

Comment 7

[Cristina Horotan [:chorotan]]

Backed out for causing multiple failures

Backout link

Push with failures

Failure log a11y
Failure log bc browser_multiselect_tabs_copy_through_drag_and_drop.js
[Failure log bc browser_tabopen.js](
Failure log bc browser_overflowScroll.js

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cebb9e8b38c
Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster

Comment 9

[Atila Butkovits]

Backed out for causing failures at browser_tabReorder_vertical.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/3385d0165a6762ad3ba52b7e5fd6b85b3c29e183

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7cebb9e8b38c16283fe744aee3240131e695898c&selectedTaskRun=Djk5sabESs-rTHDNJ9yd1Q.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=496764693&repo=autoland&lineNumber=7722
https://treeherder.mozilla.org/logviewer?job_id=496765916&repo=autoland&lineNumber=5964

Comment 10

[Nikki Sharpley (:nikkis) (she/her)]

Hi Atila. Thanks for providing those links. It looks like both of the failures, browser_tabReorder_vertical.js and browser_multiselect_tabs_copy_through_drag_and_drop.js, are in central and unrelated to my patch. They probably need an intermittent bug filed for each? I'm going to attempt landing again.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fc3318eca2c
Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fe466b3d686
Backed out changeset 9fc3318eca2c for causing bc failures @browser_multiselect_tabs_copy_through_drag_and_drop.js. CLOSED TREE

Comment 13

[Nikki Sharpley (:nikkis) (she/her)]

Please see the above comment - these failures are happening on central and not caused by my patch. Can you please re-land? Thanks!

Comment 14

[agoloman]

Hi, these failures started perma failing after you landed your push as you can see here or here.

• Backout link
• Failure Log.

Comment 15

[Nikki Sharpley (:nikkis) (she/her)]

Thanks for sharing. I'm a little confused - if my patch didn't make it to central, is there a reason why I am getting the same failures locally on the latest central? Just trying to understand.

Comment 16

[agoloman]

These failures are not on central, so it must be something related to you local repository.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2de353289e45
Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster

Comment 18

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2de353289e45