Closed Bug 1927428 Opened 17 days ago Closed 14 days ago

[Linux] Tab text and close button (X) is misaligned in expanded vertical tabs

Categories

(Firefox :: Sidebar, defect, P1)

defect

Tracking

()

RESOLVED FIXED
134 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox132 --- unaffected
firefox133 --- fixed
firefox134 --- fixed

People

(Reporter: muffinresearch, Assigned: mstriemer)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-sidebar])

Attachments

(2 files)

STR:

  • Using latest NIghtly on Ubuntu (in my case this is 24.04, note this doesn't seem to repro on Mac or Windows)
  • With sidebar.revamp and sidebar.verticalTabs true
  • Look at the text position in a tab when tabs are expanded.

What happens

  • The text is positioned too low in the tab.

What should happen

The text display should match Mac and Windows.

Other notes:

Running Mozregression found this which will hopefully help pin down where the fix needs to be

Bug 1922343 - Hide scrollbar gutter on macOS in vertical tabs r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,mconley
Differential Revision: https://phabricator.services.mozilla.com/D224363

The regression found doesn't seem to be right as this patch just involved colors. To be sure reverting it locally didn't change anything.

:mstriemer, since you are the author of the regressor, bug 1922343, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(mstriemer)

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #2)

:mstriemer, since you are the author of the regressor, bug 1922343, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

I don't think this was the regression despite running mozregression twice and getting the same answer.

Flags: needinfo?(mstriemer)
No longer regressed by: 1922343

Further investigation seems to point to bug 1922036 being the issue.

Regressed by: 1922036

Re-establishing the NI for Mark, and for input.

Flags: needinfo?(mstriemer)

Looks like it's due to the larger font size on Linux. This rule appears to be the culprit https://searchfox.org/mozilla-central/rev/b655023a1978bcad8cc2fb038b89a058b45e91a7/browser/themes/shared/tabbrowser/tabs.css#1151

Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P1

Set release status flags based on info from the regressing bug 1922036

Flags: needinfo?(mstriemer)
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/37ec9eb55d22 Handle larger system fonts in expanded vertical tabs r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley
Status: ASSIGNED → RESOLVED
Closed: 14 days ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch

The patch landed in nightly and beta is affected.
:mstriemer, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(mstriemer)

Comment on attachment 9433819 [details]
Bug 1927428 - Handle larger system fonts in expanded vertical tabs r?dao

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: Vertical tabs on Linux have the text misaligned, it is especially bad when the user has modified their system font size to be larger
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Changes are scoped to the preffed-off-by-default vertical tabs
  • String changes made/needed:
  • Is Android affected?: No
Flags: needinfo?(mstriemer)
Attachment #9433819 - Flags: approval-mozilla-beta?

Comment on attachment 9433819 [details]
Bug 1927428 - Handle larger system fonts in expanded vertical tabs r?dao

Approved for 133.0b3

Attachment #9433819 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: