1927480 - Clang-format won't recheck failures

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

The clang-format source-test task on comm- repositories only checks files that are changed in that push. This was done for the sake of time.

The unintended side effect is that if a failure is not noticed, mal-formatted files can lurk for weeks until a merge happens.

Proposed fixes:
A) Change the task configuration so that the files-changed portion is only used on try-c-c builds, all other repos would always check the full tree
B) Change the task so that on a Daily build (or a release repo push) the full tree is checked, try-c-c will always check changed files
C) Leave as is and add a cron task to run the check daily

I'm leaning towards option B. Implementation-wise, the full check could be set up as a separate task so that a full tree check can be forced on try-c-c by a developer.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1927480 - Fix clang-format on comm-central. Add task to run on whole tree. r=#thunderbuild

Removing the optimization config on comm-central prior to setting the paths
to format in the command resulted in an invalid command that always succeeded.

Add a variant that can be run through add-new-jobs to run format on the
entire tree for situations like this where mass-update is needed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/73736863b29e
Fix clang-format on comm-central. Add task to run on whole tree. r=dandarnell