Sidebar is showing in extensions popup when closing multiple tabs (and potentially in other popups)
Categories
(Firefox :: Sidebar, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr128 | --- | unaffected |
firefox132 | --- | unaffected |
firefox133 | --- | verified |
firefox134 | --- | verified |
People
(Reporter: kcochrane, Assigned: jsudiaman)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fidefe-sidebar])
Attachments
(3 files)
We should be hiding the sidebar in pop-up windows such as this extensions confirmation pop-up that shows when you close multiple tabs using the Tree Style Tabs add-on.
Reporter | ||
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Reporter | ||
Comment 1•7 days ago
|
||
moz-regression points to bug 1908019 as the change that caused this regression
Comment 2•7 days ago
|
||
:jsudiaman, since you are the author of the regressor, bug 1908019, could you take a look?
For more information, please visit BugBot documentation.
Assignee | ||
Updated•7 days ago
|
Reporter | ||
Comment 3•6 days ago
•
|
||
Will Durand pointed out that when adding --temp-profile
when using ./mach run
, the pop-up when closing multiple tabs in TST no longer shows the sidebar. Whenever you restart the browser once more and repeat the steps, the sidebar DOES show in the pop-up at this point. That might explain why we're not seeing any issues in the existing test. We may need to use a marionette test where we can restart the browser and test again.
Comment 4•6 days ago
|
||
Kelly found the regressing patch here and mentioned this in https://phabricator.services.mozilla.com/D227089 . That made me look at how webextension code opens popups. That code lives here and passes null
for the opener window. Before, that would mean we couldn't inherit sidebar state from anywhere. Now, we do inherit state (but from the pref) and so that explains why we have started opening sidebars in these windows.
(for comparison "normal" browser windows are opened in BrowserWindowTracker )
Assignee | ||
Comment 5•6 days ago
|
||
Checks to make sure that the backup state isn't being loaded in a popup window. Adds a test for the scenario which causes this bug.
Assignee | ||
Updated•6 days ago
|
Comment 6•6 days ago
|
||
Set release status flags based on info from the regressing bug 1908019
Comment 8•5 days ago
|
||
bugherder |
Comment 9•5 days ago
|
||
The patch landed in nightly and beta is affected.
:jsudiaman, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox133
towontfix
.
For more information, please visit BugBot documentation.
Assignee | ||
Comment 10•5 days ago
|
||
Checks to make sure that the backup state isn't being loaded in a popup window. Adds a test for the scenario which causes this bug.
Original Revision: https://phabricator.services.mozilla.com/D227119
Updated•5 days ago
|
Comment 11•5 days ago
|
||
beta Uplift Approval Request
- User impact if declined: Users with the
sidebar.revamp
pref enabled will see the sidebar appear in popup windows. - Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: Enable the
sidebar.revamp
pref. Close multiple tabs using the Tree Style Tabs add-on. Verify that there is no sidebar in the popup window. - Risk associated with taking this patch: Low
- Explanation of risk level: One line conditional change impacting only the sidebar.
- String changes made/needed: None.
- Is Android affected?: no
Assignee | ||
Updated•5 days ago
|
Updated•5 days ago
|
Comment 12•5 days ago
|
||
uplift |
Updated•5 days ago
|
Updated•4 days ago
|
Comment 13•4 days ago
|
||
Verified fixed using Nightly 134.0a1 (20241030214633) and Beta 133.0b1 (20241030190731) on MacOS 14, Windows 10 and Ubuntu 24.04.
Description
•