1927529 - Update dav1d to new version ef4aff75b0b56a8e1af996458ae653c0728a1596 from 2024-10-22 00:00:32

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Update Bot]

This update covers 35 commits. Here are the overall diff statistics, and then the commit information.

---

media/libdav1d/moz.yaml | 4 +-
media/libdav1d/vcs_version.h | 2 +-
third_party/dav1d/NEWS | 7 +-
third_party/dav1d/meson.build | 108 +-
third_party/dav1d/src/cdef_tmpl.c | 4 +
third_party/dav1d/src/ipred_tmpl.c | 4 +
third_party/dav1d/src/loongarch/itx.S | 73 +-
third_party/dav1d/src/mc_tmpl.c | 4 +
third_party/dav1d/src/meson.build | 17 +
third_party/dav1d/src/pal.c | 10 +-
third_party/dav1d/src/riscv/64/cdef.S | 703 ++++++++++++++++++++
third_party/dav1d/src/riscv/64/cdef16.S | 689 +++++++++++++++++++
third_party/dav1d/src/riscv/64/cpu.S | 5 +
third_party/dav1d/src/riscv/64/ipred.S | 461 +++++++++++++
third_party/dav1d/src/riscv/64/ipred16.S | 471 +++++++++++++
third_party/dav1d/src/riscv/64/itx.S | 361 ++++-----
third_party/dav1d/src/riscv/64/mc.S | 532 +++++++++++++++
third_party/dav1d/src/riscv/64/pal.S | 95 ++
third_party/dav1d/src/riscv/asm.S | 23 +-
third_party/dav1d/src/riscv/cdef.h | 31 +
third_party/dav1d/src/riscv/cpu.h | 4 +
third_party/dav1d/src/riscv/ipred.h | 74 ++
third_party/dav1d/src/riscv/mc.h | 69 +
third_party/dav1d/src/riscv/pal.h | 39 +
third_party/dav1d/src/x86/looprestoration16_sse.asm | 626 +++++------------
third_party/dav1d/src/x86/looprestoration_sse.asm | 491 ++++---------
26 files changed, 3853 insertions(+), 1054 deletions(-)

---

ef4aff75b0b56a8e1af996458ae653c0728a1596 by Henrik Gramner <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/ef4aff75b0b56a8e1af996458ae653c0728a1596
Authored: 2024-10-18 14:05:44 +0200
Committed: 2024-10-22 00:00:32 +0200

x86: Improve SSSE3 SGR asm

---

55fb9433b70711b1d78e8311220158badf486a19 by Martin Storsjö <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/55fb9433b70711b1d78e8311220158badf486a19
Authored: 2024-10-18 13:32:51 +0300
Committed: 2024-10-18 14:37:28 +0000

checkasm: Remove leftover comment

---

23f2769266401ea23e5edce3dbe13815ca0bd761 by Martin Storsjö <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/23f2769266401ea23e5edce3dbe13815ca0bd761
Authored: 2024-04-01 00:35:42 +0300
Committed: 2024-10-18 10:55:59 +0000

meson: Test support for aarch64 extensions with gas-preprocessor too

---

b13d1bc2bb1dc3c6a4601ee74857d6cf5732d0dc by Martin Storsjö <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/b13d1bc2bb1dc3c6a4601ee74857d6cf5732d0dc
Authored: 2024-10-08 09:53:10 +0300
Committed: 2024-10-18 10:55:59 +0000

meson: Move checks for gas-preprocessor earlier

---

32cf02af50f32af108a3b281c452788dccdac648 by Jean-Baptiste Kempf <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/32cf02af50f32af108a3b281c452788dccdac648
Authored: 2024-10-18 01:02:26 +0200
Committed: 2024-10-18 01:02:57 +0200

NEWS for 1.5.0

---

c3fa1db301b5b1209de21478ffe874e0d7059d70 by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/c3fa1db301b5b1209de21478ffe874e0d7059d70
Authored: 2024-10-16 18:05:28 +0000
Committed: 2024-10-16 18:06:00 +0000

NEWS: add itx to riscv list

---

789a1f652b89e10347a5ec36c446f7b4247feb71 by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/789a1f652b89e10347a5ec36c446f7b4247feb71
Authored: 2024-10-14 13:28:57 +0000
Committed: 2024-10-16 11:04:14 +0000

riscv64/itx: Replace vwadd+vnsra with vnclip

---

389450f61ea0b2057fc9ea393d3065859c4ba7f2 by Jean-Baptiste Kempf <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/389450f61ea0b2057fc9ea393d3065859c4ba7f2
Authored: 2024-10-14 19:13:19 +0200
Committed: 2024-10-14 19:21:07 +0200

NEWS: last updates about optimizations

---

79f7188c25c9df5b1c179f81cac62a1bb22938b6 by Luca Barbato <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/79f7188c25c9df5b1c179f81cac62a1bb22938b6
Authored: 2024-10-13 21:49:21 +0200
Committed: 2024-10-13 21:51:36 +0200

NEWS: add an entry for the Power9 optimization

---

572c5a669d067d175a36f9ae9c7682b958811a62 by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/572c5a669d067d175a36f9ae9c7682b958811a62
Authored: 2024-10-13 18:05:11 +0000
Committed: 2024-10-13 18:11:27 +0000

riscv: Fix argon test failure

---

257b04f91c1cfca3e05d83ed79b672781ead3e59 by yuanhecai <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/257b04f91c1cfca3e05d83ed79b672781ead3e59
Authored: 2024-10-10 20:37:43 +0800
Committed: 2024-10-12 15:19:57 +0800

loongarch: fix argon tests failure

---

b2e7f06c72cad3fe9027efea9751f48d8ea7e357 by Bogdan Gligorijević <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/b2e7f06c72cad3fe9027efea9751f48d8ea7e357
Authored: 2024-08-11 03:42:49 +0200
Committed: 2024-10-09 21:00:08 +0200

riscv64/mc: warp_8x8 and warp_8x8t 8bpc

---

56f6d166023c6826e877ae324ed362eab2a8b4ca by Niklas Haas <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/56f6d166023c6826e877ae324ed362eab2a8b4ca
Authored: 2024-05-23 13:19:07 +0200
Committed: 2024-10-09 16:18:42 +0200

riscv64/mc: Re-order instructions

---

3d12677c545270dfa249333c547563168513a8ca by Niklas Haas <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/3d12677c545270dfa249333c547563168513a8ca
Authored: 2024-04-29 15:52:14 +0200
Committed: 2024-10-09 16:18:42 +0200

riscv64/mc: Add bidir functions

---

50ac82603a0915c5b257e3322338596575a080ed by Niklas Haas <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/50ac82603a0915c5b257e3322338596575a080ed
Authored: 2024-05-10 14:08:05 +0200
Committed: 2024-10-09 16:18:42 +0200

riscv: Add $vtype helper definitions

---

cc7d8773eeb07f3f7ac9b9b51afeb74d1ca11dd3 by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/cc7d8773eeb07f3f7ac9b9b51afeb74d1ca11dd3
Authored: 2024-05-06 16:57:13 -0400
Committed: 2024-10-09 16:18:42 +0200

riscv64/mc: Branchless vsetvl in blend_v function

---

2da8107ec15db3a536def840ec9164add1b9770a by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/2da8107ec15db3a536def840ec9164add1b9770a
Authored: 2024-05-08 09:45:46 -0400
Committed: 2024-10-09 16:18:42 +0200

riscv64/mc: Branchless vsetvl in blend_h function

---

b374b24c0f986920790ec97a30eab169fdbead77 by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/b374b24c0f986920790ec97a30eab169fdbead77
Authored: 2024-05-05 13:26:46 -0400
Committed: 2024-10-09 16:18:42 +0200

riscv64/mc: Branchless vsetvl in blend function

---

0e3f70e898f41fa7a533c42848319e0548723aab by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/0e3f70e898f41fa7a533c42848319e0548723aab
Authored: 2024-05-06 16:13:21 -0400
Committed: 2024-10-09 16:18:42 +0200

riscv64/mc: Add VLEN=256 8bpc RVV blend_v function

---

a5b9544866c528176c68ab59ea36913cf0b1a677 by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/a5b9544866c528176c68ab59ea36913cf0b1a677
Authored: 2024-05-05 07:32:24 -0400
Committed: 2024-10-09 16:18:42 +0200

riscv64/mc: Add VLEN=256 8bpc RVV blend_h function

---

83485c5092e52eb76b1f4b18a8a308382a4ecddb by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/83485c5092e52eb76b1f4b18a8a308382a4ecddb
Authored: 2024-05-04 23:25:58 -0400
Committed: 2024-10-09 16:18:42 +0200

riscv64/mc: Add VLEN=256 8bpc RVV blend function

---

7f2bb2fbc9c54829cb32db281842fc7cd72b555e by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/7f2bb2fbc9c54829cb32db281842fc7cd72b555e
Authored: 2024-05-06 17:21:16 -0400
Committed: 2024-10-09 16:18:42 +0200

riscv: Move get_vlenb() from checkasm_ to dav1d_

---

01da36ebdf9ea55b7f24392107a6a706fbd4d169 by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/01da36ebdf9ea55b7f24392107a6a706fbd4d169
Authored: 2024-05-04 19:25:27 -0400
Committed: 2024-10-09 16:18:42 +0200

riscv64/mc: Add 8bpc RVV blend_v function

---

d3a94f11948ba6159d311f08e55afde1f05469d5 by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/d3a94f11948ba6159d311f08e55afde1f05469d5
Authored: 2024-05-04 13:35:25 -0400
Committed: 2024-10-09 16:18:42 +0200

riscv64/mc: Add 8bpc RVV blend_h function

---

f851fcd0b44c29a19edca86f6bcf9e587f5cb3bb by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/f851fcd0b44c29a19edca86f6bcf9e587f5cb3bb
Authored: 2024-05-04 09:36:50 -0400
Committed: 2024-10-09 16:18:42 +0200

riscv64/mc: Add 8bpc RVV blend function

---

848c5a2dbbd410c7f15d059b5c44ea1a85f2c53f by Bogdan Gligorijević <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/848c5a2dbbd410c7f15d059b5c44ea1a85f2c53f
Authored: 2024-07-09 00:55:54 +0200
Committed: 2024-10-09 16:18:42 +0200

Tone down loop to only 2 iterations

---

a0a08d8543498f80d760ea3caaa7962af11005d8 by Bogdan Gligorijević <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/a0a08d8543498f80d760ea3caaa7962af11005d8
Authored: 2024-07-06 00:43:47 +0200
Committed: 2024-10-09 16:18:42 +0200

Scalar dc calculation

---

c8749f06e5d27b48ae54aabd00307d036f1bbca4 by Bogdan Gligorijević <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/c8749f06e5d27b48ae54aabd00307d036f1bbca4
Authored: 2024-06-01 21:54:11 +0200
Committed: 2024-10-09 16:18:42 +0200

riscv64/itx: Special case 16x16 8bpc dct_dct eob=0

---

0cdf1b4be546ab9d33ac30c205f6bc3086e250bc by Bogdan Gligorijević <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/0cdf1b4be546ab9d33ac30c205f6bc3086e250bc
Authored: 2024-07-12 12:06:37 +0200
Committed: 2024-10-09 16:18:42 +0200

ipred_paeth

---

b830ac82bb74aac96234c545377cdb0ee2b6d58e by Bogdan Gligorijević <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/b830ac82bb74aac96234c545377cdb0ee2b6d58e
Authored: 2024-07-03 01:04:34 +0200
Committed: 2024-10-09 16:18:42 +0200

pal_pred

---

44541dfa6b6fae55e9ee82489c37405f980a12a2 by Bogdan Gligorijević <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/44541dfa6b6fae55e9ee82489c37405f980a12a2
Authored: 2024-07-01 23:36:49 +0200
Committed: 2024-10-09 16:18:42 +0200

ipred_smooth

---

d711f974ebeb611142621bb1ff6a667341469dab by Bogdan Gligorijević <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/d711f974ebeb611142621bb1ff6a667341469dab
Authored: 2024-06-29 23:36:32 +0200
Committed: 2024-10-09 16:18:42 +0200

ipred cfl functions

---

2f5bfc37b08c1eaa7e62a3754176eea48563d08d by Bogdan Gligorijević <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/2f5bfc37b08c1eaa7e62a3754176eea48563d08d
Authored: 2024-06-10 23:12:11 +0200
Committed: 2024-10-09 16:18:42 +0200

riscv64/cdef: filter functions

---

f223436bb674b1eca98bac2dcb9c05f019c6a0e5 by Bogdan Gligorijević <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/f223436bb674b1eca98bac2dcb9c05f019c6a0e5
Authored: 2024-07-08 21:34:14 +0200
Committed: 2024-10-09 16:18:42 +0200

pal_idx_finish

---

38f74bdc4625221bca460af936b4c778afb255d0 by Nathan E. Egge <[e-mail]>

https://code.videolan.org/videolan/dav1d/commit/38f74bdc4625221bca460af936b4c778afb255d0
Authored: 2024-05-05 12:23:44 -0400
Committed: 2024-10-09 16:18:42 +0200

riscv: Allow multiple .option arch with vararg ext

---

Comment 1

[Update Bot]

./mach vendor media/libdav1d/moz.yaml reported an error editing moz.build files:

Latest commit is ef4aff75b0b56a8e1af996458ae653c0728a1596 from 2024-10-22T00:00:32.000+02:00
Fetching code archive from https://code.videolan.org/videolan/dav1d/-/archive/ef4aff75b0b56a8e1af996458ae653c0728a1596.tar.gz
Retaining wanted in-tree files.
Cleaning third_party/dav1d to import changes.
Unpacking upstream files for third_party/dav1d.
Retaining wanted files from upstream changes.
Removing excluded files from upstream changes.
Removing: [5 items in /tmp/tmp_9vxaiuq/doc: Doxyfile.in.in, PATENTS, dav1d_logo.png, dav1d_logo.svg and meson.build, 7 items in /tmp/tmp_9vxaiuq/examples: dav1dplay.c, dp_fifo.c, dp_fifo.h, dp_renderer.h, dp_renderer_placebo.c, dp_renderer_sdl.c and meson.build, 18 (omitted) items in /tmp/tmp_9vxaiuq/package/crossfiles, /tmp/tmp_9vxaiuq/package/snap/snapcraft.yaml, /tmp/tmp_9vxaiuq/tests/checkasm/arm/checkasm_32.S, /tmp/tmp_9vxaiuq/tests/checkasm/arm/checkasm_64.S, 12 (omitted) items in /tmp/tmp_9vxaiuq/tests/checkasm, /tmp/tmp_9vxaiuq/tests/checkasm/loongarch/checkasm.S, /tmp/tmp_9vxaiuq/tests/checkasm/riscv/checkasm_64.S, /tmp/tmp_9vxaiuq/tests/checkasm/x86/checkasm.asm, /tmp/tmp_9vxaiuq/tools/compat/getopt.c, 6 items in /tmp/tmp_9vxaiuq/tools: dav1d.c, dav1d.manifest, dav1d.rc.in, dav1d_cli_parse.c, dav1d_cli_parse.h and meson.build, 7 items in /tmp/tmp_9vxaiuq/tools/input: annexb.c, demuxer.h, input.c, input.h, ivf.c, parse.h and section5.c, 8 items in /tmp/tmp_9vxaiuq/tools/output: md5.c, muxer.h, null.c, output.c, output.h, xxhash.c, y4m2.c and yuv.c, /tmp/tmp_9vxaiuq/.gitignore, /tmp/tmp_9vxaiuq/.gitlab-ci.yml]
Copying to third_party/dav1d.
Checking for update actions
action: copy-file src: /builds/worker/checkouts/gecko/third_party/dav1d/include/vcs_version.h.in dst: /builds/worker/checkouts/gecko/media/libdav1d/vcs_version.h
action: replace-in-file file: /builds/worker/checkouts/gecko/media/libdav1d/vcs_version.h
action: copy-file src: /builds/worker/checkouts/gecko/third_party/dav1d/include/dav1d/version.h dst: /builds/worker/checkouts/gecko/media/libdav1d/version.h
Registering changes with version control.
Checking for a spurious update.
Version 'ef4aff75b0b56a8e1af996458ae653c0728a1596' has changed 24 files.
Updating moz.yaml.
Found release: 7072e79faa8b8f387960b4a738139c98c270277f (2024-10-07T13:04:34.000+02:00).

Found revision: 7072e79faa8b8f387960b4a738139c98c270277f

Updating moz.build files
Found 6 files added and 0 files removed.
Could not add third_party/dav1d/src/riscv/64/cdef.S to the appropriate moz.build file
Could not add third_party/dav1d/src/riscv/64/cdef16.S to the appropriate moz.build file
Could not add third_party/dav1d/src/riscv/64/ipred.S to the appropriate moz.build file
Could not add third_party/dav1d/src/riscv/64/ipred16.S to the appropriate moz.build file
Could not add third_party/dav1d/src/riscv/64/mc.S to the appropriate moz.build file
Could not add third_party/dav1d/src/riscv/64/pal.S to the appropriate moz.build file
This is a deficiency in ./mach vendor . Please review the affected files before committing.

We're going to continue processing the update; but we may fail because we couldn't handle these files. If we do succeed, you may want to add these files to the 'exclude' key in the moz.yaml file, so they are excluded from the source tree and ignored in the future.

Comment 2

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=534238a1a957f55fa820769cd9a97c05b178014a

Comment 3

[Update Bot]

Attachment: Bug 1927529 - Update dav1d to ef4aff75b0b56a8e1af996458ae653c0728a1596

Comment 4

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

• browser/components/urlbar/tests/browser-tips/browser_picks.js
  • 1 of 4 failed on the same (retriggered) task
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-3 (fiatXBKMTNyyPPVKjU6Xww)

Needs Investigation (Possible Intermittents):

• browser/components/urlbar/tests/browser-tips/browser.toml
  • 1 of 4 failed on the same (retriggered) task
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-3 (fiatXBKMTNyyPPVKjU6Xww)
• test-windows10-64-2009-qr/debug-gtest-1proc - 2 of 4 failed on the same (retriggered) task (failed: fXXbjoRHQqWi7NNG5VrxXQ, QBEdx57tTS2uGnvFt3zOWA)

Known Issues:

• browser/base/content/test/fullscreen/browser_fullscreen_tab_preview.js
  - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-7 (QbR89EwEROiElH9zjOKPTA)

• browser/base/content/test/performance/browser_startup.js
  - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-1 (EpWUmv1nTTaSiaGAuglMug)
  - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-1 (Kee9QDLcS-i0aHQLt77Ong)

• browser/components/preferences/tests/browser_experimental_features_resetall.js
  - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-4 (Ja-OPfS5RemU-2QepCbo6g)

• browser/components/sidebar/tests/browser/browser_vertical_tabs_stacking_context.js
  - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-2 (JEbUep16S_O47MExazfSZA)

• browser/extensions/formautofill/test/browser/creditCard/browser_creditCard_telemetry.js
  - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-6 (Ks8efDvzToCHk4g85SvUsw)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor media/libdav1d/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b26d51f8c917
Update dav1d to ef4aff75b0b56a8e1af996458ae653c0728a1596 r=chunmin

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/b26d51f8c917