Closed Bug 1927537 Opened 9 days ago Closed 7 days ago

Update googletest to new version 5ed21863955149a5a877a53d7d5045b6919090ed from 2024-10-28 06:57:15

Categories

(Testing :: GTest, enhancement)

enhancement

Tracking

(firefox134 fixed)

RESOLVED FIXED
134 Branch
Tracking Status
firefox134 --- fixed

People

(Reporter: update-bot, Assigned: ahal)

Details

(Whiteboard: [3pl-filed][task_id: Xsw7k1MUSc2Y6qGoHG-l1A])

Attachments

(2 files)

This update covers 7 commits. Here are the overall diff statistics, and then the commit information.


third_party/googletest/googlemock/include/gmock/gmock-matchers.h | 97 +++++++--
third_party/googletest/googletest/include/gtest/gtest.h | 4 +-
third_party/googletest/googletest/src/gtest.cc | 17 +-
third_party/googletest/moz.yaml | 4 +-
4 files changed, 87 insertions(+), 35 deletions(-)


5ed21863955149a5a877a53d7d5045b6919090ed by Peter Boström <pbos@google.com>

https://github.com/google/googletest/commit/5ed21863955149a5a877a53d7d5045b6919090ed
Authored: 2024-10-27 23:56:39 -0700
Committed: 2024-10-27 23:57:15 -0700

Use FAIL() in GTEST_SKIP() documentation

This replaces EXPECT_EQ(0, 1) which would fail if hit.

PiperOrigin-RevId: 690491467
Change-Id: Ieff4e616348254f29200e0ba1d9a6900a2eea130

Files Modified:

  • docs/advanced.md

df1544bcee0c7ce35cd5ea0b3eb8cc81855a4140 by Abseil Team <absl-team@google.com>

https://github.com/google/googletest/commit/df1544bcee0c7ce35cd5ea0b3eb8cc81855a4140
Authored: 2024-10-16 06:39:05 -0700
Committed: 2024-10-16 06:39:54 -0700

Avoid creating std::vector<const T> in UnorderedElementsAreArrayMatcher and others.

std::vector<const T> for trivially relocatable types is not allowed by C++ and is rejected by libc++ starting from https://github.com/llvm/llvm-project/commit/4e112e5c1c8511056030294af3264da35f95d93c
PiperOrigin-RevId: 686487841
Change-Id: I3c90c7c0a6e8e23ffa5ebd1702a3f30ebc4a702f

Files Modified:

  • googlemock/include/gmock/gmock-matchers.h

62df7bdbc10887e094661e07ec2595b7920376fd by Abseil Team <absl-team@google.com>

https://github.com/google/googletest/commit/62df7bdbc10887e094661e07ec2595b7920376fd
Authored: 2024-10-14 10:12:38 -0700
Committed: 2024-10-14 10:13:58 -0700

This change adjusts how ASSERT_NEAR and EXPECT_NEAR treats infinity, such that ASSERT_NEAR(inf, inf, 0) passes. This makes the behavior more consistent with ASSERT_EQ(inf, inf) which succeeds.

Some examples of asserts that now pass:

ASSERT_NEAR(inf, inf, 0)
ASSERT_NEAR(-inf, inf, inf)
ASSERT_NEAR(inf, x, inf)  // x is any finite floating point value

PiperOrigin-RevId: 685748133
Change-Id: I7b3af377773e8e0031e4c6b86830cbbf76bf20c6

Files Modified:

  • docs/reference/assertions.md
  • googletest/src/gtest.cc
  • googletest/test/gtest_unittest.cc

71815bbf7de6e10c11821d654a2fae2cf42de0f7 by Abseil Team <absl-team@google.com>

https://github.com/google/googletest/commit/71815bbf7de6e10c11821d654a2fae2cf42de0f7
Authored: 2024-10-04 20:53:30 -0700
Committed: 2024-10-04 20:54:14 -0700

Automated Code Change

PiperOrigin-RevId: 682549952
Change-Id: Ica81f0020c3001c01543a5851dae7d0b42730c66

Files Modified:

  • googlemock/test/gmock-function-mocker_test.cc

a1e255a582377e1006bb88a408ac3f933ba7c916 by Abseil Team <absl-team@google.com>

https://github.com/google/googletest/commit/a1e255a582377e1006bb88a408ac3f933ba7c916
Authored: 2024-10-01 09:32:16 -0700
Committed: 2024-10-01 09:35:17 -0700

Optional(): Add support for std::optional<>-like types lacking bool conversion.

PiperOrigin-RevId: 681053268
Change-Id: If80ba667fd4c91340e1405a9691f5ca0350fa9eb

Files Modified:

  • googlemock/include/gmock/gmock-matchers.h
  • googlemock/test/gmock-matchers-misc_test.cc

6dae7eb4a5c3a169f3e298392bff4680224aa94a by Abseil Team <absl-team@google.com>

https://github.com/google/googletest/commit/6dae7eb4a5c3a169f3e298392bff4680224aa94a
Authored: 2024-09-16 14:48:46 -0700
Committed: 2024-09-16 14:49:27 -0700

Use matcher's description in AnyOf when matcher has no explanation.

PiperOrigin-RevId: 675298308
Change-Id: I32d32cafebc7a63fd03e6d957c3a47043d71e5d9

Files Modified:

  • googlemock/include/gmock/gmock-matchers.h
  • googlemock/test/gmock-matchers-arithmetic_test.cc
  • googlemock/test/gmock-matchers-containers_test.cc
  • googlemock/test/gmock-matchers-misc_test.cc

0953a17a4281fc26831da647ad3fcd5e21e6473b by Abseil Team <absl-team@google.com>

https://github.com/google/googletest/commit/0953a17a4281fc26831da647ad3fcd5e21e6473b
Authored: 2024-08-29 08:16:49 -0700
Committed: 2024-08-29 08:17:22 -0700

Automated Code Change

PiperOrigin-RevId: 668944316
Change-Id: I65aa0a4f3b8a980242849963a3e921ec7fd92b28

Files Modified:

  • googlemock/test/gmock-pp_test.cc

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Assignee: nobody → ahal
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/022eed677b0e Update googletest to 5ed21863955149a5a877a53d7d5045b6919090ed r=ahal https://hg.mozilla.org/integration/autoland/rev/972799ea9573 Apply mozilla patches for googletest r=ahal
Status: NEW → RESOLVED
Closed: 7 days ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: