1927595 - [Isolated Process] Fix GeckoViewTest Priority Tests for Isolated Processes

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[Olivia Hall [:olivia]]

When running in Isolated Process mode, GeckoViewTest has failing tests at:

• setPriorityHint
• processPriorityTest
• setTabActiveKeepsTabAtHighPriority

Because it cannot access the file /proc/<PID>/oom_score to calculate a priority score for the tests because it is checking the score of other processes. Likely need to find an alternate calculation for the test or make the test privledged or accept that this test will only run in this mode, where the file access is available.

Comment 1

[Olivia Hall [:olivia]]

I tend to think it makes more sense to accept this as a condition of the test, so I wouldn't consider it blocking isolated process, but might be a nice-to-have, if we can find an alternate way to access this info.

Comment 2

[Olivia Hall [:olivia]]

I'm going to see if we can find a new way to formulate these tests that doesn't rely on privileged process information.

Comment 3

[Olivia Hall [:olivia]]

Attachment: Bug 1927595 - Open GeckoViewTest Priority Tests for Isolated Processes

Issue was getContentProcessesOomScore was attempting to read other process's oom scores.

This patch:

• Adjusts getContentProcessesOomScore to read the oom score through the test privileged uiAutomation
• Opens tests in GeckoViewTest gated by isolated process
• Runs ktlint on GeckoViewTest

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c804cd87495
Open GeckoViewTest Priority Tests for Isolated Processes r=geckoview-reviewers,m_kato

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3c804cd87495