Closed Bug 1927801 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 48853 - Display resize observer loop notifications in devtools

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
134 Branch
Tracking Status
firefox134 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48853 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48853
Details from upstream follow.

Philip Rogers <pdr@chromium.org> wrote:

Display resize observer loop notifications in devtools

Resize observer loop notifications errors that are not canceled should
appear in the devtools console so authors have some indication of the
error. This patch does this with two changes:

  1. A valid script state is used so the exception is not dropped in
    MainThreadDebugger::ExceptionThrown.
  2. A ScriptValue of the error message is used so a message appears in
    the console. Without a ScriptValue, MainThreadDebugger::ExceptionThrown
    will print "Uncaught null".

The console behavior is not specified so two tentative tests have been
added (Safari passes these). A TODO has been added to provide a useful
source location, as suggested by https://crbug.com/40667137#comment10.

Fixed: 40667137
Change-Id: Id20c977efd1fc03caba517ecec3bf3b0a9f53163
Reviewed-on: https://chromium-review.googlesource.com/5970814
WPT-Export-Revision: 10c6f545456fc786380c4462696cedb9313a4f1d

Component: web-platform-tests → Layout
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6f86f5d845c4 [wpt PR 48853] - Display resize observer loop notifications in devtools, a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in before you can comment on or make changes to this bug.