1927802 - [wpt-sync] Sync PR 48854 - Throw exception for popovers/dialogs in non-active documents

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48854 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48854
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Throw exception for popovers/dialogs in non-active documents

See discussion at:
https://github.com/whatwg/html/issues/10659

and spec PR at:
https://github.com/whatwg/html/pull/10705

Fixed: 373684393
Change-Id: I50e400ee526775f915f006865301fff2f04016b4

Reviewed-on: https://chromium-review.googlesource.com/5943740
WPT-Export-Revision: dd4fcb0f1e63b46cb717af5cf7ebca342e9c68d9

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=17e31c3bf2dfe59cb460058c7be38d3a65c82b69

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 3
PASS: 8
FAIL: 4

Chrome

OK : 3
PASS: 9
FAIL: 3

Safari

OK : 3
PASS: 8
FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/interactive-elements/the-dialog-element/dialog-active-document.html [wpt.fyi]
  • showModal should throw when the document isn't active: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html [wpt.fyi]
  • when opening multiple dialogs, the most recently opened is rendered on top: FAIL (Chrome: PASS, Safari: FAIL)
  • When the document is not attached to any pages, showModal() should throw.: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/popovers/popover-active-document.html [wpt.fyi]
  • showPopover should throw when the document isn't active: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac6cc55b745e
[wpt PR 48854] - Throw exception for popovers/dialogs in non-active documents, a=testonly
https://hg.mozilla.org/integration/autoland/rev/6e7ae2cd2a92
[wpt PR 48854] - Update wpt metadata, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ac6cc55b745e
https://hg.mozilla.org/mozilla-central/rev/6e7ae2cd2a92