1927956 - Cache Fakespot API responses for open tabs

Status: RESOLVED INCOMPLETE

(Firefox Graveyard :: Shopping, task, P2)

Description

[Fred Chasen [:fchasen]]

Now that there is just a single sidebar panel, when switching to an existing tab we don't want to re-request the analysis data if there hasn't been a navigation but still need to replace whatever data that is currently in the sidebar with the data for the tabs location.

We'll want to cache the data for the product in tab until that tab navigates to something else. This isn't going to need to be a cache of the API responses but just of the current product tabs in a window.

Navigating the page or reloading will need to expire the cache for that tab / uri.

Comment 1

[Fred Chasen [:fchasen]]

Attachment: Bug 1927956 - Cache product data for product URLs in open tabs. r?#shopping-reviewers!

Comment 2

[kpatenio]

Attachment: WIP: Bug 1927956 - Cache analysis results in ShoppingProduct for open tabs. [REBASED AND PoC]

Comment 3

[Fred Chasen [:fchasen]]

kpatenio found some issues with the current patch only listening for tab changes while the RC sidebar is open and so not removing items from the cache when tabs are closed and the sidebar is not open. This is a result of this caching strategy originally only sticking around until the sidebar was closed.

That doesn't make much sense not that the sidebar auto-closes, so initially I switched the cache to be a static member on ReviewCheckerChild but it seems like the cache might need to move to somewhere like ShoppingUtils.

However it seems that we may be able to pass cache headers from the API through OHTTP, which along with the fixes to flickering when switching tabs, may be a better and more long term solution to this.

Comment 4

[David Lawrence [:dkl]]

This bug is being closed because we are closing the Bugzilla component.
If this still needs attention, please re-open and change component to
the appropriate component or "General".