Closed
Bug 1927964
Opened 8 months ago
Closed 5 months ago
Improve responsive design of integrated RC
Categories
(Firefox Graveyard :: Shopping, defect, P2)
Firefox Graveyard
Shopping
Tracking
(firefox136 fixed)
RESOLVED
FIXED
136 Branch
Tracking | Status | |
---|---|---|
firefox136 | --- | fixed |
People
(Reporter: kpatenio, Assigned: kpatenio)
References
Details
(Whiteboard: [fidefe-RCSidebar])
Attachments
(1 file, 1 obsolete file)
With WIP changes like https://phabricator.services.mozilla.com/D226075, the RC UI doesn't look quite right with different sidebar sizes. The feedback I received so far includes:
Recommendations panel
- letter grade should be below product image
Settings panel
- font-size for the toggle descriptions (not labels) are the same size as the labels, when they should be smaller
- toggles are "sticking out" with the min sidebar width size. We might have to adjust how we "group" the elements for the panel
Empty states:
- with larger / max width, illustration, description, and CTA button should be centered. Illustration should maintain its original size
- with the min width, illustration should be slightly smaller
Bonus:
- loading state boxes should be rounded (no sharp corners)
- loading state boxes are slightly bigger than they should be (no scroll must be needed to see all of them)
We also have a new Figma spec for the layout with different sidebar widths: https://www.figma.com/design/GnCtw7DmPtlSEIfjatHtSI/Review-Checker-in-sidebar?node-id=12309-117085&node-type=frame&m=dev
Severity: -- → S3
Type: task → defect
Points: --- → 3
Priority: -- → P2
Whiteboard: [fidefe-RCSidebar]
Updated•8 months ago
|
Updated•7 months ago
|
Attachment #9442017 -
Attachment is obsolete: true
Updated•6 months ago
|
Attachment #9439149 -
Attachment description: WIP: Bug 1927964 - Improve responsive design of integrated RC. r=#shopping-reviewers! → Bug 1927964 - Improve responsive design of integrated RC. r=#shopping-reviewers!
Pushed by kpatenio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2dba433ee1e
Improve responsive design of integrated RC. r=shopping-reviewers,rking
Comment 4•5 months ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Updated•29 days ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•