Closed
Bug 1928092
Opened 11 days ago
Closed 26 minutes ago
QM: Temporary origin is not added to cached origins if directory metadata creation fails
Categories
(Core :: Storage: Quota Manager, defect, P2)
Core
Storage: Quota Manager
Tracking
()
RESOLVED
FIXED
134 Branch
Tracking | Status | |
---|---|---|
firefox134 | --- | fixed |
People
(Reporter: janv, Assigned: janv)
References
(Blocks 2 open bugs)
Details
Attachments
(3 files)
QM_TRY_INSPECT(const bool& created, EnsureOriginDirectory(*directory));
if (created) {
const int64_t timestamp = PR_Now();
// Only creating .metadata-v2 to reduce IO.
QM_TRY(MOZ_TO_RESULT(CreateDirectoryMetadata2(*directory, timestamp,
/* aPersisted */ false,
aOriginMetadata)));
FullOriginMetadata fullOriginMetadata =
FullOriginMetadata{aOriginMetadata,
/* aPersisted */ false, timestamp};
AddTemporaryOrigin(fullOriginMetadata);
// Don't need to traverse the directory, since it's empty.
InitQuotaForOrigin(fullOriginMetadata, ClientUsageArray(),
/* aUsageBytes */ 0);
}
AddTemporaryOrigin
should be called before CreateDirectoryMetadata2
.
Assignee | ||
Updated•6 days ago
|
Assignee | ||
Comment 1•6 days ago
|
||
Assignee | ||
Comment 2•6 days ago
|
||
Assignee | ||
Comment 3•5 days ago
|
||
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe6b17b10f75
QM: Add a new artificial failure for CreateDirectoryMetadata2; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/a2adddbb10d9
QM: Add a disabled test for a failure during temporary origin initialization; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/6e6ecf3fc853
QM: Add temporary origin to cached origins even if directory metadata creation fails; r=dom-storage-reviewers,asuth
Comment 5•26 minutes ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fe6b17b10f75
https://hg.mozilla.org/mozilla-central/rev/a2adddbb10d9
https://hg.mozilla.org/mozilla-central/rev/6e6ecf3fc853
Status: ASSIGNED → RESOLVED
Closed: 26 minutes ago
status-firefox134:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•