1928122 - Add setPrefValue in the JS shell

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Ryan Hunt [:rhunt]]

From talking with Christian, we're hoping to be able to do some differential testing of wasm lazy tiering/inlining and that requires runtime flipping of prefs. We have a getPrefValue, but no setPrefValue. I think it should be possible to support this in the JS shell.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1928122 - Add setPrefValue to JS shell. r?jandem

Adds a setPrefValue that mirrors the getPrefValue function. It is only
available in the JS shell because the browser has its own way of setting
a pref.

I had to either define this builtin away from all the other JS pref functions
in js.cpp, or else move all the JS pref functions up in the file so this
builtin can be used in shell_functions. I chose to move them all up, but
I'm fine the other way.

I also renamed the functions from JSPref to just Pref to match the name of
the builtin, but again I can go the other way too.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f92139bc6d0f
Add setPrefValue to JS shell. r=jandem

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing SM failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/c0b0e3bde4400b1324a08ed035b935a0c8db7a16

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/max-module.js

Comment 4

[Ryan Hunt [:rhunt]]

Unrelated test got added to the commit when I was fixing a review comment.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e865540c089e
Add setPrefValue to JS shell. r=jandem

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e865540c089e