1928340 - Pointer lock is released unexpectedly when the DevTools panel is closed using F12

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Edgar Chen [:edgar] (PTO 2/2 ~ 2/6)]

STR:

1. Load https://mdn.github.io/dom-examples/pointer-lock/.
2. Open DevTools panel via F12.
3. Click the red circle to request pointer lock.
4. Close DevTools panel via F12.

Expected result:
Pointer is still locked.

Actual result:
Pointer lock is released.

Comment 1

[Edgar Chen [:edgar] (PTO 2/2 ~ 2/6)]

It is because when DevTools panel is closed, the Document::OnPageHide is called when the document of DevTools is destroyed, which calls PointerLockManager::Unlock. And the PointerLockManager::Unlock just unconditionally notify content process to release pointer lock in https://searchfox.org/mozilla-central/rev/783f3fca1dda58353f7d3075744dd48b66e00e5e/dom/base/PointerLockManager.cpp#195-201. In such case, we should not need to ask content to release the pointer lock.

Comment 2

[Edgar Chen [:edgar] (PTO 2/2 ~ 2/6)]

Attachment: Bug 1928340 - Add some log for pointer lock;

Comment 3

[Edgar Chen [:edgar] (PTO 2/2 ~ 2/6)]

Attachment: Bug 1928340 - Prevent unexpected pointer lock release from the parent process;

Comment 4

[Edgar Chen [:edgar] (PTO 2/2 ~ 2/6)]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=58c4e79da4daaad6bd7104fdd615034c262595f7

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe8b67c873fb
Add some log for pointer lock; r=smaug
https://hg.mozilla.org/integration/autoland/rev/41eeee000de1
Prevent unexpected pointer lock release from the parent process; r=smaug

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/fe8b67c873fb
https://hg.mozilla.org/mozilla-central/rev/41eeee000de1