1928477 - Update Intervention for admissions.nid.edu

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, task)

Description

[Thomas Wisniewski [:twisniewski][PTO until Mar.16]]

The desktop page no longer seems to block Firefox, though the mobile page does. So we only have to spoof the UA on Android.

Comment 1

[Thomas Wisniewski [:twisniewski][PTO until Mar.16]]

Attachment: Bug 1928477 - only override the UA string for admissions.nid.edu on Android; r?ksenia

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b912facfa97c
only override the UA string for admissions.nid.edu on Android; r=ksenia,webcompat-reviewers

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b912facfa97c

Comment 4

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b912facfa97c
only override the UA string for admissions.nid.edu on Android;
r=ksenia,webcompat-reviewers

Perfherder has detected a browsertime performance change.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
12%	twitter FirstVisualChange	windows11-64-shippable-qr	cold fission webrender	88.40 -> 77.52	Before/After
12%	reddit-billgates-post-2.billg fcp	macosx1015-64-shippable-qr	cold fission webrender	153.61 -> 135.41
12%	reddit-billgates-post-2.hot fcp	macosx1015-64-shippable-qr	cold fission webrender	153.61 -> 135.41
12%	reddit-billgates-post-2.top fcp	macosx1015-64-shippable-qr	cold fission webrender	153.61 -> 135.41

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 42452

For more information on performance sheriffing please see our FAQ.

Comment 5

[Thomas Wisniewski [:twisniewski][PTO until Mar.16]]

Note that this is not the only patch which landed at the same time, and any Twitter and Reddit improvements should have come about from removing our related webcompat intervention in https://phabricator.services.mozilla.com/D227706 (where we no longer need that intervention).