1928616 - Show sidebars button doesn't move to its newly default place after updating from an older build

Status: RESOLVED WORKSFORME

(Firefox :: Sidebar, defect)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Found in

• Firefox 133.0b2

Affected versions

• Firefox 133.0b2
• Firefox 134.0a1

Affected platforms

• All

Preconditions

• Set the following prefs:
  sidebar.revamp - true
  *Have an older version of Firefox installed ready to be updated

Steps to reproduce

1. See that sidebars button is shown next to the refresh icon
2. Update Firefox to the latest version

Expected result

• The button takes its new default place on the left of the strip (before back button)

Actual result

• The button is still in the same place as before the update

Additional Notes

• See the issue in the following attachment.
• Entering customize toolbar, the user can press "Restore defaults" and it will move the Show sidebars button to its newly default place.

Comment 1

[Sarah Clements [:sclements]]

Hi Catalin, I think this is okay as if the sidebar has been moved we're not trying to override any changes in positioning that might've been made. On a new profile, for instance, I see that its before the back button when sidebar.revamp is flipped. So I'd expect that in release when a user is in that branch with the pref on, it will show correctly. If they've already found the pref and flipped it, I don't think we can do much about that (and also, if they have moved the button around, we don't override that).