1929175 - Update android nightly application-services version bump to new version df8c16859ebeff46cb4fcfb65d7ca9dd6d4fa6d3 from 2024-11-05 05:03:37

Status: RESOLVED FIXED

(Fenix :: General, enhancement)

Description

[Update Bot]

This update covers 4 commits. Here are the overall diff statistics, and then the commit information.

---

mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

df8c16859ebeff46cb4fcfb65d7ca9dd6d4fa6d3 by Drew Willcoxon <[e-mail]>

https://github.com/mozilla/application-services/commit/df8c16859ebeff46cb4fcfb65d7ca9dd6d4fa6d3
Authored: 2024-11-02 22:19:22 -0700
Committed: 2024-11-04 18:33:37 +0000

Fix a comment

Files Modified:

• components/suggest/src/weather.rs

---

ea0654349e61fac908435722cdf87025c57d5002 by Drew Willcoxon <[e-mail]>

https://github.com/mozilla/application-services/commit/ea0654349e61fac908435722cdf87025c57d5002
Authored: 2024-11-02 22:16:06 -0700
Committed: 2024-11-04 18:33:37 +0000

Improve matching logic for city abbreviations and airport codes

Files Modified:

• components/suggest/src/geoname.rs
• components/suggest/src/util.rs
• components/suggest/src/weather.rs

---

578e31c21d8151d1e82c96a73de6fb68751f22fe by Drew Willcoxon <[e-mail]>

https://github.com/mozilla/application-services/commit/578e31c21d8151d1e82c96a73de6fb68751f22fe
Authored: 2024-10-31 22:16:09 -0700
Committed: 2024-11-04 18:33:37 +0000

Bug 1928544 - For weather suggestions, don't match on airport codes or abbreviations when they're the only term in the query

In the original GeoNames data, each alternate name has an associated
iso_language that indicates what kind of name it is. In addition to actual
language codes, it can also be "abbr" for an abbreviation ("NY") and a handful
of other values that all mean an airport code ("PDX"). We need to keep track of
the iso_language per alternate so that we don't match on an abbreviation or
airport code when it's the only term in the query. (Or, we could store an
is_abbreviation in the RS data, but that's worse in the long term, and it's
also good to be consistent with the original data where feasible IMO.)

I modified the schema and RS structs accordingly. In DownloadedGeoname, I
changed the name of alternate_names to alternate_names_2 because, while I'd
like to uplift this change, it's not clear there's enough time. So we may need
to support the old alternate_names on 133.

The other main change is to filter_map_chunks(): The filter-map function is
now passed the chunk size, and weather uses it to tell whether the chunk is the
last one in the query string.

Files Modified:

• components/suggest/src/geoname.rs
• components/suggest/src/schema.rs
• components/suggest/src/util.rs
• components/suggest/src/weather.rs

---

bb620f4b3f4e53311559e3c39fef0849f9d2590d by Ben Dean-Kawamura <[e-mail]>

https://github.com/mozilla/application-services/commit/bb620f4b3f4e53311559e3c39fef0849f9d2590d
Authored: 2024-11-01 09:52:15 -0400
Committed: 2024-11-04 15:08:35 +0000

Updating taskcluster policy to allow comment actions

This is needed to test
https://github.com/mozilla/application-services/pull/6437.

Files Modified:

• .taskcluster.yml

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=c205fae5de7d023f63795549d7132494703388b3

Comment 2

[Update Bot]

Attachment: Bug 1929175 - Update android nightly application-services version bump to df8c16859ebeff46cb4fcfb65d7ca9dd6d4fa6d3

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13177f433ae9
Update android nightly application-services version bump to df8c16859ebeff46cb4fcfb65d7ca9dd6d4fa6d3 r=pascalc

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/13177f433ae9

Comment 5

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Investigation (Possible Intermittents):

• generate-profile-android-x86-shippable/opt - 1 of 1 failed (failed: MzZlzDiZR527baV3g5B0ZA)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.