1929184 - firefox-128.4.0esr compile does throws 646 warnings: 'this' pointer is null in ../dist/include/mozilla/MozPromise.h:678:21: warning: 'this' pointer is null [-Wnonnull]

Status: UNCONFIRMED

(Core :: XPCOM, defect)

Description

[tt_1]

Attachment: summary

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

I downloaded firefox-128.4.0esr sources and compiled them for linux

Actual results:

my package manager does give a summary of all the severe compiler warnings, and it showed 646 warnings of this kind:

../dist/include/mozilla/MozPromise.h:678:21: warning: 'this' pointer is null [-Wnonnull]

Expected results:

I've attached all the warnings in one plain text file, I will upload a full build log in a few hours.

I'm not certain wether this is a real issue, but I'm pretty sure there were maybe a one digit number of warnings for firefox-115esr, and there was recent plumbing in the xpcom file refered here.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::XPCOM' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Jan Varga [:janv]]

Can you check if replacing MOZ_DIAGNOSTIC_ASSERT with MOZ_RELEASE_ASSERT at https://searchfox.org/mozilla-esr128/rev/3c4447c7bdfad5ca714bd208ca56193e527edc89/xpcom/threads/MozPromise.h#675 gets rid of the warning ?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:nika, could you have a look please?

For more information, please visit BugBot documentation.