1929384 - Window should not close if there are still collapsed tab groups

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, task, P2)

Description

[Stephen Thompson [:sthompson]]

Current behavior:

Create 3 tabs. Select the first 2 tabs and create a new tab group from them. Collapse the tab group. Close the third tab (the only standalone tab that is left). The Firefox browser window closes.

This surprised a number of tab group users. It feels very bad and confusing to end up in that situation.

tabbrowser.js:_beginRemoveTab chooses whether to close the Firefox window when:

• the tab being closed is visible
• the number of visible tabs on the tab strip is 1 (tabs in collapsed tab groups are NOT counted as visible)
• the window is a full browser window (not a popup)
• the browser.tabs.closeWindowWithLastTab pref is true (which is the default)

We can detect when the user is closing the last visible tab BUT there is a collapsed group (or multiple) still present. We can take a different action instead of closing the window.

Comment 1

[Stephen Thompson [:sthompson]]

Attachment: Bug 1929384 - do not close window if there are still collapsed tab groups r=dao,dwalker,jswinarton

When closing the last visible tab, if there are any collapsed tab groups, make one of the tabs in a tab group active. Based on pre-existing behavior, activating a tab in a collapsed tab group causes the tab group to expand.

Currently, if you close the last visible tab while you still have collapsed tab groups present on the tab bar, the browser window will close. This is surprising and sad behavior for users.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb62d287a016
do not close window if there are still collapsed tab groups r=dao,tabbrowser-reviewers

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/fb62d287a016

Comment 5

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 134.0a1 (2024-11-21)