1929400 - Minor BookmarksBarButton clean-ups.

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1929400 - Remove CUI special cases for BookmarksBarButton. r=mak,aminomancer

We can just tag the widget as not removable.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1929400 - Don't use :has() to hide BookmarksBarButton message. r=aminomancer

This is faster, no point in making customize mode slower for something
that almost never shows up anyways.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

As we triage this, it would be helpful to have a bit more context here. Shane or Emilio?

Comment 4

[Jason Prickett]

Looks like Shane has handled the needinfo in the patches.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:pdahiya, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[Punam Dahiya [:pdahiya]]

NI @mviar to discuss within squad and provide remaining review feedback needed from OMC thanks!

Comment 7

[Meg Viar [:mviar]]

@jprickett will review and leave feedback.

Comment 8

[Pascal Chevrel:pascalc]

Please don't set bugs as S1 unless it is really an S1. This level of severity corresponds to a chemspill situation requiring an immediate unplanned dot release.
https://wiki.mozilla.org/BMO/UserGuide/BugFields#bug_severity

S1 (Catastrophic) Blocks development/testing, may impact more than 25% of users, causes data loss, likely dot release driver, and no workaround available

Thanks

Comment 9

[Emily McMinn :emcminn]

Oops, sorry about that! I think I was bulk editing yesterday and caught this one by mistake. Thanks for correcting it :)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e950a5780b8
Remove CUI special cases for BookmarksBarButton. r=mak,omc-reviewers,jprickett
https://hg.mozilla.org/integration/autoland/rev/b566b3023da0
Don't use :has() to hide BookmarksBarButton message. r=aminomancer,desktop-theme-reviewers,omc-reviewers,dao

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6e950a5780b8
https://hg.mozilla.org/mozilla-central/rev/b566b3023da0