1929493 - Minor cleanups to the wasm inlining budget logic

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Julian Seward [:jseward]]

Bug 1927061 introduced inlining budgets for functions and for entire modules.
That has unfortunately a couple of rough edges that should be fixed.

• the situation where a per-function or per-module budget is exactly zero is
  ambiguous. As a result the logging machinery (MOZ_LOG=wasmPerf:3) can print
  an "Inlining budget for fI=... exceeded" a different number of times from the
  number shown in the final "... functions overran inlining budget" message.

  It also means the "Inlining budget for fI=... exceeded" message is printed
  for all functions when we have --wasm-compiler=ion.

  This patch removes the ambiguity by having a value of zero mean "budget not
  exceeded"; hence it is the 0-vs-negative transition that is important. This
  fixes the above problems.

• two JS_LOGs were not protected by #ifdef JS_JITSPEW as they should have
  been.

Comment 1

[Julian Seward [:jseward]]

Attachment: Bug 1929493 - Minor cleanups to the wasm inlining budget logic. r=rhunt.

Bug 1927061 introduced inlining budgets for functions and for entire modules.
That has unfortunately a couple of rough edges that this patch fixes.

• The situation where a per-function or per-module budget is exactly zero is
  ambiguous. As a result the logging machinery (MOZ_LOG=wasmPerf:3) can print
  the "Inlining budget for fI=... exceeded" message a different number of
  times from the number shown in the final "... functions overran inlining
  budget" message.

  It also causes the "Inlining budget for fI=... exceeded" message to be
  printed for all functions when we have --wasm-compiler=ion.

  This patch removes the ambiguity and fixes the above by having a value of
  zero mean "budget not exceeded"; hence it is the zero-to-negative transition
  that is important.

• two JS_LOGs were not protected by #ifdef JS_JITSPEW as they should have
  been.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d84c7649de8
Minor cleanups to the wasm inlining budget logic.  r=rhunt.

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/9d84c7649de8