1929801 - [MIPS64] Failed to build JS on mips64 platform (emitBigIntPtrDiv)

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Xuan Chen]

Steps to reproduce:

build firefox on x86_64 with ac_add_options --enable-simulator=mips64

Actual results:

2:53.77 /mozilla-unified/js/src/jit/CodeGenerator.cpp:11597:3: error: use of undeclared identifier 'emitBigIntPtrDiv'
2:53.77 11597 | emitBigIntPtrDiv(ins, lhs, rhs, output);
2:53.77 | ^
2:53.83 /mozilla-unified/js/src/jit/CodeGenerator.cpp:11667:3: error: use of undeclared identifier 'emitBigIntPtrMod'
2:53.83 11667 | emitBigIntPtrMod(ins, temp, rhs, output);
2:53.83 | ^

Expected results:

These errors shouldn't exist.

Comment 1

[Xuan Chen]

(In reply to Xuan Chen from comment #0)

Steps to reproduce:

build firefox on x86_64 with ac_add_options --enable-simulator=mips64

Correction: building the js engine should be enough to reproduce this problem.

Comment 2

[Xuan Chen]

Attachment: Bug 1929801 - [MIPS64] Implement undefined and MOZ_CRASH methods. r=anba

This patch implements missing methods that cause builds to fail
for MIPS64, and implements lowerBigIntPtrDiv and lowerBigIntPtrMod
properly as the codegen can properly emit them now.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f202e1c73018
[MIPS64] Implement undefined and MOZ_CRASH methods. r=anba

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f202e1c73018