192984 - trunk topcrash with master password tab timeout [@ nsPK11Token::GetAskPasswordTimeout]

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P2)

Description

[Jan Carpenter]

This stack signature is a trunk topcrash

STACK TRACE:
Source File :
c:/builds/seamonkey/mozilla/security/manager/ssl/src/nsPK11TokenDB.cpp line : 333
 
====================================================================================================
     Count   Offset    Real Signature
[ 5   nsPK11Token::GetAskPasswordTimeout f438c6c9 -
nsPK11Token::GetAskPasswordTimeout ]
[ 3   nsPK11Token::GetAskPasswordTimeout 111fd9ff -
nsPK11Token::GetAskPasswordTimeout ]
[ 1   nsPK11Token::GetAskPasswordTimeout b1398ca1 -
nsPK11Token::GetAskPasswordTimeout ]
[ 1   nsPK11Token::GetAskPasswordTimeout 7566c376 -
nsPK11Token::GetAskPasswordTimeout ]
[ 1   nsPK11Token::GetAskPasswordTimeout 4883f619 -
nsPK11Token::GetAskPasswordTimeout ]
 
     Crash date range: 2003-02-08 to 2003-02-11
     Min/Max Seconds since last crash: 51 - 7461
     Min/Max Runtime: 210 - 7461
 
     Count   Platform List 
     6   Windows NT 5.1 build 2600
     5   Windows NT 5.0 build 2195
 
     Count   Build Id List 
     10   2003021008
     1   2003020708
 
     No of Unique Users         7
 
 Stack trace(Frame) 

	 nsPK11Token::GetAskPasswordTimeout
[c:/builds/seamonkey/mozilla/security/manager/ssl/src/nsPK11TokenDB.cpp  line 333] 
	 XPTC_InvokeByIndex
[c:/builds/seamonkey/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp 
line 102] 
	 XPCWrappedNative::CallMethod
[c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp  line 2025] 
	 XPC_WN_CallMethod
[c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp 
line 1293] 
	 js_Invoke	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 841] 
	 js_Interpret	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 2804] 
	 js_Invoke	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 857] 
	 js_InternalInvoke	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 932] 
	 JS_CallFunctionValue	[c:/builds/seamonkey/mozilla/js/src/jsapi.c  line 3433] 
	 nsJSContext::CallEventHandler
[c:/builds/seamonkey/mozilla/dom/src/base/nsJSEnvironment.cpp  line 1043] 
	 nsJSEventListener::HandleEvent
[c:/builds/seamonkey/mozilla/dom/src/events/nsJSEventListener.cpp  line 183] 
	 nsEventListenerManager::HandleEventSubType
[c:/builds/seamonkey/mozilla/content/events/src/nsEventListenerManager.cpp  line
1217] 
	 nsEventListenerManager::HandleEvent
[c:/builds/seamonkey/mozilla/content/events/src/nsEventListenerManager.cpp  line
2218] 
	 nsXULElement::HandleDOMEvent
[c:/builds/seamonkey/mozilla/content/xul/content/src/nsXULElement.cpp  line 3349] 
	 PresShell::HandleDOMEventWithTarget
[c:/builds/seamonkey/mozilla/layout/html/base/src/nsPresShell.cpp  line 6277] 
	 nsButtonBoxFrame::MouseClicked
[c:/builds/seamonkey/mozilla/layout/xul/base/src/nsButtonBoxFrame.cpp  line 200] 
	 nsButtonBoxFrame::HandleEvent
[c:/builds/seamonkey/mozilla/layout/xul/base/src/nsButtonBoxFrame.cpp  line 147] 
	 PresShell::HandleEventInternal
[c:/builds/seamonkey/mozilla/layout/html/base/src/nsPresShell.cpp  line 6246] 
	 PresShell::HandleEventWithTarget
[c:/builds/seamonkey/mozilla/layout/html/base/src/nsPresShell.cpp  line 6181] 
	 nsEventStateManager::CheckForAndDispatchClick
[c:/builds/seamonkey/mozilla/content/events/src/nsEventStateManager.cpp  line 2867] 
	 nsEventStateManager::PostHandleEvent
[c:/builds/seamonkey/mozilla/content/events/src/nsEventStateManager.cpp  line 1849] 
	 PresShell::HandleEventInternal
[c:/builds/seamonkey/mozilla/layout/html/base/src/nsPresShell.cpp  line 6250] 
	 PresShell::HandleEvent
[c:/builds/seamonkey/mozilla/layout/html/base/src/nsPresShell.cpp  line 6136] 
	 nsViewManager::HandleEvent
[c:/builds/seamonkey/mozilla/view/src/nsViewManager.cpp  line 2210] 
	 nsView::HandleEvent	[c:/builds/seamonkey/mozilla/view/src/nsView.cpp  line 304] 
	 nsViewManager::DispatchEvent
[c:/builds/seamonkey/mozilla/view/src/nsViewManager.cpp  line 1948] 
	 HandleEvent	[c:/builds/seamonkey/mozilla/view/src/nsView.cpp  line 83] 
	 nsWindow::DispatchEvent
[c:/builds/seamonkey/mozilla/widget/src/windows/nsWindow.cpp  line 1119] 
	 nsWindow::DispatchWindowEvent
[c:/builds/seamonkey/mozilla/widget/src/windows/nsWindow.cpp  line 1136] 
	 nsWindow::DispatchMouseEvent
[c:/builds/seamonkey/mozilla/widget/src/windows/nsWindow.cpp  line 5378] 
	 ChildWindow::DispatchMouseEvent
[c:/builds/seamonkey/mozilla/widget/src/windows/nsWindow.cpp  line 5633] 
	 nsWindow::ProcessMessage
[c:/builds/seamonkey/mozilla/widget/src/windows/nsWindow.cpp  line 4133] 
	 nsWindow::WindowProc
[c:/builds/seamonkey/mozilla/widget/src/windows/nsWindow.cpp  line 1403] 
	 USER32.dll + 0x27ad7 (0x77d67ad7)  
	 USER32.dll + 0x2ccd4 (0x77d6ccd4)  
	 USER32.dll + 0x4455 (0x77d44455)  
	 USER32.dll + 0x95d5 (0x77d495d5)  
	 nsAppShellService::Run
[c:/builds/seamonkey/mozilla/xpfe/appshell/src/nsAppShellService.cpp  line 480] 
	 main1	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1289] 
	 main	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1639] 
	 WinMain	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1660] 
	 WinMainCRTStartup()  
	 kernel32.dll + 0x214c7 (0x77e814c7)   
 



URLs\COMMENTS:


     (17121049)	Comments: After unsuccesfull changing of the master password  I
clicked on "ask for master password after N minutes"
     (17106178)	URL: www.macromedia.com
     (17106178)	Comments: Tried to set master password.
     (17105081)	Comments: Editing Security&Privacy Preferences from out of
"Mail"  wanted click on "Reset Masterpassword"
     (17098927)	URL: http://203.197.150.179/rms/index.html
     (17098927)	Comments: In preferences : Set master password to radio button
to timeout  and click on the text field to enter the timout and the crash is 
reproducable.
     (17098925)	URL: http://203.197.150.179/rms/index.html
     (17098925)	Comments: Looking in yout preferences window.  I do not know
about the 203.... url above.  
     (17097288)	Comments: changing setting in security option  password checking
from first time only to every x minutes...mistake occurs everytime i try...no
matter what i've done before
     (17043046)	Comments: I was trying to set a master password but it seems to
be not working correctly.

Comment 1

[Jan Carpenter]

oops, wrong component.

Comment 2

[sairuh (rarely reading bugmail)]

looks like encryption/security, so over to PSM.

Comment 3

[Asa Dotzler [:asa]]

This looks high on the list of topcrashers. We should get this for 1.3. It
sounds like people are triggering the crash by either attempting to change the
master password or maybe by simply visiting the master password preference panel.

It's also worth noting that setting the master password is broken, reported in
bug 192917 with JS errors mentioned.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Could there be an out-of-date .xpt file that we're not deleting?  (I could see
something like that causing both bugs.)

Comment 5

[Kai Engert (:KaiE:)]

> Could there be an out-of-date .xpt file that we're not deleting?  (I could see
> something like that causing both bugs.)

junruh reports (see bug 192197 comment 12) that there are indeed two .xpt files
left over when installing 1.3b into a 1.3a directory. I don't know where those
xpt files come from.

Comment 6

[John Unruh]

Kai must be referring to bug 192917

Comment 7

[Michael Lefevre]

*** Bug 193324 has been marked as a duplicate of this bug. ***

Comment 8

[Peter 'vt100' Schwindt]

crashes also using WinXP, SP1; Build 2003021108

Comment 9

[Michael Lefevre]

*** Bug 192748 has been marked as a duplicate of this bug. ***

Comment 10

[Michael Lefevre]

just took me 10 minutes to re-find this bug and I knew it was here... adding
description to summary to make it findable.

Comment 11

[Daniel Veditz [:dveditz]]

*** Bug 192855 has been marked as a duplicate of this bug. ***

Comment 12

[Asa Dotzler [:asa]]

Stephane, Sean, do we think this will be fixed by the fix at bug 193241 ?

Comment 13

[Sean Su]

The crashes seemed to have stopped after 02/10/03 (the day of 1.3b release). 
Either the users cleaned up their system and installed again, or the bug was
somehow fixed.

It seems more likely that users would cleanup their previous version of mozilla
than to install the next day's nightly build, then reinstalled again.  In which
case bug 193241 would be likely to take care of the crasher.

The patch for bug 193241 also cleaned up other left over files, so if it was
really the cause of the problem, we should no longer see it.

Comment 14

[Asa Dotzler [:asa]]

OK, pulling from blocker list

Comment 15

[Jay Patel [:jay]]

This crash didn't stop after 2/10.  It might have appeared that way because that
was the build date for the M130B release and we had a lot of crashes with those
builds showing up in Talkback data.

I see a few incidents with 2/16 and 2/19 MozillaTrunk builds...so this crash is
definitely happing in some way.

Comment 16

[John Unruh]

Marking fixed. No builds IDs from Feb. 20th forward show this crash - "
nsPK11Token::GetAskPasswordTimeout". This problem was fixed by bug 193241,
available on the 20th.

Comment 17

[John Unruh]

Verified fixed.