1929925 - Duplicated F accesskey in View | Folders: _F_older Pane Header and _F_avorite Folders

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect, P2)

Description

[Robert Bradley]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:132.0) Gecko/20100101 Firefox/132.0

Steps to reproduce:

I have nine email folders. I make INBOX and DELETED my favourite folders in each one. Then I can press ALT/V/F/F to change to view the folders. Some twit has changed the menu so that "Folder pane header" and "Favourite Folders" both have the first letter "F" underlined which means it can be selected by typing that letter. Because of the recent change in error, ALT/V/F/F no longer works properly to switch between folder favourite view and all folders view. Please put it back again. You shouldn't have the same letter underlined twice in the same menu.

Actual results:

ALT/V/F/F no longer works properly because of a recent change. I am using version 128.4.2 esr (64 bit) and it worked in earlier versions of 128.

Expected results:

ALT/V/F/F should switch between Folder favourite view and all folders view (or whatever you had selected previously). It's only been doing this as it should for years and years and years.

Comment 1

[Magnus Melin [:mkmelin]]

This didn't work in earlier v128 versions, and not in 115 either. Blame points to bug 1812391

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1929925 - Fix duplicated F accesskey in View | Folders: _F_older Pane Header and _F_avorite Folders. r=#thunderbird-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/14ebcc579ae9
Fix duplicated F accesskey in View | Folders: _F_older Pane Header and _F_avorite Folders. r=vineet

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9436340 [details]
Bug 1929925 - Fix duplicated F accesskey in View | Folders: _F_older Pane Header and _F_avorite Folders. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1812391
User impact if declined: duplicate accesskey (couldn't use keyboard to get to the second menu)
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): no risk, just accesskey change

Comment 5

[Corey Bryant]

Comment on attachment 9436340 [details]
Bug 1929925 - Fix duplicated F accesskey in View | Folders: _F_older Pane Header and _F_avorite Folders. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Martin Giger [:freaktechnik]]

It appears this upset the l1nt-conflicts linter: https://firefoxci.taskcluster-artifacts.net/VSVL9OPHSL24F3gYGoUslg/0/public/logs/live_backing.log

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 133.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/8fc7248098c1

Comment 8

[Magnus Melin [:mkmelin]]

(In reply to Martin Giger [:freaktechnik] from comment #6)

It appears this upset the l1nt-conflicts linter: https://firefoxci.taskcluster-artifacts.net/VSVL9OPHSL24F3gYGoUslg/0/public/logs/live_backing.log

I don't know what to do about that. The linter is wrong in this case. The accesskey would be locale dependent so it's like a typo fix.

Comment 9

[Corey Bryant]

Comment on attachment 9436340 [details]
Bug 1929925 - Fix duplicated F accesskey in View | Folders: _F_older Pane Header and _F_avorite Folders. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 10

[Corey Bryant]

Thunderbird 128.5.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/e85b94d7b4a8