1929929 - [wpt-sync] Sync PR 49031 - Revert "View transition layered capture: determine geometry based on box model"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49031 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49031
Details from upstream follow.

[e-mail] <[e-mail]> wrote:

Revert "View transition layered capture: determine geometry based on box model"

This reverts commit 9bd85f446ff63c0e14c4c951e6c6d882e66ab2c7.

Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8731914295759642129

Sample failed build: https://ci.chromium.org/b/8731914295759642129

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5953705&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8731914295759642129&type=BUG

Original change's description:

View transition layered capture: determine geometry based on box model

Instead of capturing the border offset, we capture the following
layout sizes to determine sizing, in addition to the border box:

• padding box

• content box

• The box-sizing property

• In layered capture mode, we use the content box size as the
  reference box for positioning the snapshot, so that padding take
  effect.

• The ::view-transition-image-pair pseudo-element now has
  position:relative so that it gets affected by padding. It has the
  content box size.

• The width/height of the group is determined by the box-sizing
  property, and it receives the computed padding.

Bug: 375395117
Change-Id: I18fe5126fbfac58b0619043cc5521ea1f280e457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5953705
Reviewed-by: Khushal Sagar \<[e-mail]>
Reviewed-by: Philip Rogers \<[e-mail]>
Reviewed-by: Arthur Sonzogni \<[e-mail]>
Commit-Queue: Noam Rosenthal \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1379706}

Bug: 375395117
Change-Id: Ibb2eedd23b1010eb909a97589629905971c473fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6001797
Commit-Queue: [e-mail] \<[e-mail]>
Bot-Commit: [e-mail] \<[e-mail]>
Owners-Override: [e-mail] \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1379736}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 49031 applied with additional changes from upstream: 07dfce3f1885843deaa9a2ecd978317f7f25e9ab

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=829627d1855f93359be65f96ddb552c46ba8badf

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

TIMEOUT: 2

Chrome

PASS : 1
FAIL : 1

Safari

PASS : 1
FAIL : 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /css/css-view-transitions/layered-capture/border-offset.tentative.html [wpt.fyi]: TIMEOUT

New Tests That Don't Pass

• /css/css-view-transitions/layered-capture/border-offset.tentative.html [wpt.fyi]: TIMEOUT (Chrome: PASS, Safari: PASS)
• /css/css-view-transitions/layered-capture/box-model-capture.tentative.html [wpt.fyi]: TIMEOUT (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a50b5bc447af
[wpt PR 49031] - Revert "View transition layered capture: determine geometry based on box model", a=testonly

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/a50b5bc447af