1929972 - New callout trigger for sidebar tools triggering when tools panels are closing instead of opening

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect)

Description

[Kelly Cochrane [:kcochrane]]

In bug 1902667, I was getting some Linux test failures because we were awaiting some things for the ASRouter here, so I moved the await this.checkShouldShowCalloutSurveys(view); line after the lines to toggle the sidebar panel open which has caused my check for isToolOpening to be incorrect.

To fix this, we should move the check for isToolOpening to the showView function before the toggle logic.

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1929972 - Fix for new sidebar callout trigger being called as sidebar panel is closing instead of opening

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8401556b09c
Fix for new sidebar callout trigger being called as sidebar panel is closing instead of opening r=sidebar-reviewers,sclements

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/d8401556b09c

Comment 4

[Alexandru Bejenaru [:abejenaru], Ecosystem QA]

Hello. We were unable to reproduce this issue anymore using Firefox Nightly 134.0a1 BUILD ID: 20241113215256. Verified on Windows 10 x64, Ubuntu 22.04 and macOS 14.7. The callout is now correctly triggered when opening the sidebar. As a result I'm marking this ticket as Verified Fixed, thanks!