1930008 - Form with one address line has address-line2 part added twice

Status: NEW

(Toolkit :: Form Autofill, task, P3)

Description

[Neil Deakin]

1. Have a form with a single address line: <input id="addressInput" name="shippingAddress">
2. Add an address for autofillin with two or more lines, such as 50 First St\nApartment 6
3. Fill in that address into the form.

The address is filled in as "50 First St Apartment 6 Apartment 6" with the apartment duplicated.

This is because getAdaptedProfiles is called twice, one at https://searchfox.org/mozilla-central/rev/5f2c1701846a54c484d7dd46a291b796f5a67cac/toolkit/components/formautofill/FormAutofillChild.sys.mjs#725 when the autocomplete popup is generated.

Then it is called again when preview/fillin occurs. This causes the address transformation to occur twice. Although it could be worked around by modifying the transformer to remove old values, it would ideal to not perform any of the transformations multiple times.