Closed Bug 1930056 Opened 1 month ago Closed 1 month ago

Tabstrip height changes when closing multiple tabs

Categories

(Toolkit :: UI Widgets, defect)

Firefox 131
x86_64
Windows 10
defect

Tracking

()

VERIFIED FIXED
134 Branch
Tracking Status
firefox-esr128 --- unaffected
firefox132 --- wontfix
firefox133 --- verified
firefox134 --- verified

People

(Reporter: 6k64x4ma, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached video AGDRec.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:133.0) Gecko/20100101 Firefox/133.0

Steps to reproduce:

  1. Set ui.prefersReducedMotion to 1 (reduced motion).
  2. Pin any tab.
  3. Open about:about and duplicate tab until the scroller appears.
    (I have seen the issue with random pages other than about:about, but it seems to happen more frequently with about: pages.)
  4. Select the pinned tab.
  5. Right-click the pinned tab > Close Multiple Tabs > Close Tabs to Right or Close Other Tabs.

Actual results:

  • Sometimes tabstrip height changes and the content moves up and down.

Expected results:

  • Tabstrip height doesn't change.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=773aed942ff98525ee9bc2c03fd96dbd6c0eee96&tochange=9d4782d16aacb9b51e440042a677f6c5c68a0ca9

Keywords: regression
OS: Unspecified → Windows 10
Regressed by: 1913322
Hardware: Unspecified → x86_64

:emilio, since you are the author of the regressor, bug 1913322, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(emilio)

In the situation in comment 0, the pinned tabs are absolutely positioned
until we recompute the position / fire the overflow event, which now
fires later. Thus, for a frame, we might have an "empty" tabstrip.

Fix this by ensuring that the tabstrip doesn't shrink under the minimum
height.

Rework a bit the variables to avoid repeating the math a third time.

Assignee: nobody → emilio
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(emilio)

Set release status flags based on info from the regressing bug 1913322

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/138d80ec44f8 Avoid empty tabstrip from shrinking. r=tabbrowser-reviewers,desktop-theme-reviewers,dao
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(emilio)

Comment on attachment 9436469 [details]
Bug 1930056 - Avoid empty tabstrip from shrinking. r=#tabbrowser-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: Trivial css regression fix
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial
  • String changes made/needed: none
  • Is Android affected?: No
Flags: needinfo?(emilio)
Attachment #9436469 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9436469 [details]
Bug 1930056 - Avoid empty tabstrip from shrinking. r=#tabbrowser-reviewers

Approved for 133.0b8

Attachment #9436469 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified fixed on Nightly 134.0a1 (20241112093250) and Beta 133.0b8 (20241111165552)

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: